Make toolchain2013.py work properly if there's a space in the temp path.

Make toolchain2013.py work properly if there's a space in the temp path.

TBR=maruel@chromium.org
R=scottmg@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=254932

[viettrungluu, 2014-03-05 00:11:19]

I'm in your Windoze touching your code.

[scottmg, 2014-03-05 00:15:37]

https://codereview.chromium.org/184103027/diff/1/win_toolchain/toolchain2013.py
File win_toolchain/toolchain2013.py (right):

https://codereview.chromium.org/184103027/diff/1/win_toolchain/toolchain2013....
win_toolchain/toolchain2013.py:201: rc = os.system(('""%s" /quiet '
Thanks for fixing, can you you use

  rc = subprocess.call([blah, blah, blah, blah])

instead? It'll do the quoting properly.

[viettrungluu, 2014-03-05 00:39:33]

Thanks, PTAL.

https://codereview.chromium.org/184103027/diff/1/win_toolchain/toolchain2013.py
File win_toolchain/toolchain2013.py (right):

https://codereview.chromium.org/184103027/diff/1/win_toolchain/toolchain2013....
win_toolchain/toolchain2013.py:201: rc = os.system(('""%s" /quiet '
On 2014/03/05 00:15:37, scottmg wrote:
> Thanks for fixing, can you you use
> 
>   rc = subprocess.call([blah, blah, blah, blah])
> 
> instead? It'll do the quoting properly.

Done. I thought maybe there was a reason you were using os.system instead of
subprocess.call.

[scottmg, 2014-03-05 02:51:35]

lgtm

[viettrungluu, 2014-03-05 03:22:04]

The CQ bit was checked by viettrungluu@chromium.org

[commit-bot: I haz the power, 2014-03-05 03:22:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/184103027/20001

[commit-bot: I haz the power, 2014-03-05 03:23:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 03:23:42]

Presubmit check for 184103027-20001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    depot_tools/win_toolchain/toolchain2013.py

Presubmit checks took 92.3s to calculate.

[scottmg, 2014-03-05 03:26:40]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-03-05 03:26:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/184103027/20001

[commit-bot: I haz the power, 2014-03-05 03:28:25]

Change committed as 254932