win_toolchain/toolchain2013.py - Issue 184103027: Make toolchain2013.py work properly if there's a space in the temp path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: win_toolchain/toolchain2013.py

Issue 184103027: Make toolchain2013.py work properly if there's a space in the temp path. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: subprocess.call Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: win_toolchain/toolchain2013.py

diff --git a/win_toolchain/toolchain2013.py b/win_toolchain/toolchain2013.py

index 0cda5903964931872f52a8f0d4adf0bd39522519..201e6c7b4d2cb28589513f0d2457dd5da3f9efe9 100755

--- a/win_toolchain/toolchain2013.py

+++ b/win_toolchain/toolchain2013.py

@@ -196,10 +196,11 @@ def DownloadSDK8():

'Running sdksetup.exe to download Win8 SDK (may request elevation)...\n')

count = 0

while count < 5:

- rc = os.system(target_path + ' /quiet '

- '/features OptionId.WindowsDesktopDebuggers '

- 'OptionId.WindowsDesktopSoftwareDevelopmentKit '

- '/layout ' + standalone_path)

+ rc = subprocess.call([target_path,

+ '/quiet',

+ '/features', 'OptionId.WindowsDesktopDebuggers',

+ 'OptionId.WindowsDesktopSoftwareDevelopmentKit',

+ '/layout', standalone_path])

if rc == 0:

return standalone_path

count += 1

« no previous file with comments | « no previous file | no next file » | no next file with comments »