Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 184103016: Autofill: Refactoring to support fetching password after a username is selected (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address gcasto's comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/autofill_agent.cc
diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc
index b39ceb2077ce7850779ae530d6e551e83a6d3b86..0e12ec93ea87c681b1677f93f8d702976e2a5f38 100644
--- a/components/autofill/content/renderer/autofill_agent.cc
+++ b/components/autofill/content/renderer/autofill_agent.cc
@@ -442,13 +442,12 @@ void AutofillAgent::OnAcceptDataListSuggestion(const base::string16& value) {
}
void AutofillAgent::OnAcceptPasswordAutofillSuggestion(
- const base::string16& username) {
- // We need to make sure this is handled here because the browser process
- // skipped it handling because it believed it would be handled here. If it
- // isn't handled here then the browser logic needs to be updated.
- bool handled = password_autofill_agent_->DidAcceptAutofillSuggestion(
+ const base::string16& username,
+ const base::string16& password) {
+ bool handled = password_autofill_agent_->AcceptAutofillSuggestionWithPassword(
element_,
- username);
+ username,
+ password);
DCHECK(handled);
}

Powered by Google App Engine
This is Rietveld 408576698