components/autofill/content/common/autofill_messages.h - Issue 184103016: Autofill: Refactoring to support fetching password after a username is selected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_messages.h

Issue 184103016: Autofill: Refactoring to support fetching password after a username is selected (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address gcasto's comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/browser/content_autofill_driver_unittest.cc ('k') | components/autofill/content/renderer/autofill_agent.h » ('j') | components/autofill/content/renderer/password_autofill_agent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/common/autofill_messages.h

diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h

index d97dbf1e25641be03a7a002d7cee4dedca4a0784..6d840c6af02781700763a4a6b073ab95450bc695 100644

--- a/components/autofill/content/common/autofill_messages.h

+++ b/components/autofill/content/common/autofill_messages.h

@@ -134,9 +134,11 @@ IPC_MESSAGE_ROUTED1(AutofillMsg_AcceptDataListSuggestion,

IPC_MESSAGE_ROUTED1(AutofillMsg_GeneratedPasswordAccepted,

base::string16 /* generated_password */)

-// Tells the renderer that the password field has accept the suggestion.

-IPC_MESSAGE_ROUTED1(AutofillMsg_AcceptPasswordAutofillSuggestion,

- base::string16 /* username value*/)

+// Tells the renderer that a password autofill suggestion was accepted, and

+// that the username and password should be set to the given values.

+IPC_MESSAGE_ROUTED2(AutofillMsg_AcceptPasswordAutofillSuggestion,

+ base::string16 /* username value */,

+ base::string16 /* password value */)

Ilya Sherman 2014/03/18 00:14:27 nit: The commented out bits should be variable nam

Patrick Dubroy 2014/03/28 15:44:22 Ok, fixed here.

// Tells the renderer that this password form is not blacklisted. A form can

// be blacklisted if a user chooses "never save passwords for this site".