Autofill: Refactoring to support fetching password after a username is selected

components/autofill/content/common/autofill_messages.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message file, hence no include guard.
 
 #include <string>
 
 #include "base/time/time.h"
 #include "components/autofill/content/common/autofill_param_traits_macros.h"
@@ skipping 116 matching lines @@
 
 // Sets the currently selected node's value to be the given data list value.
 IPC_MESSAGE_ROUTED1(AutofillMsg_AcceptDataListSuggestion,
                     base::string16 /* accepted data list value */)
 
 // Tells the renderer to populate the correct password fields with this
 // generated password.
 IPC_MESSAGE_ROUTED1(AutofillMsg_GeneratedPasswordAccepted,
                     base::string16 /* generated_password */)
 
-// Tells the renderer that the password field has accept the suggestion.
-IPC_MESSAGE_ROUTED1(AutofillMsg_AcceptPasswordAutofillSuggestion,
-                    base::string16 /* username value*/)
+// Tells the renderer that a password autofill suggestion was accepted, and
+// that the username and password should be set to the given values.
+IPC_MESSAGE_ROUTED2(AutofillMsg_AcceptPasswordAutofillSuggestion,
+                    base::string16 /* username value */,
+                    base::string16 /* password value */)

[Ilya Sherman, 2014/03/18 00:14:27]

nit: The commented out bits should be variable names.  (This file is currently
not consistent about that, but that's the desired state.)

[Patrick Dubroy, 2014/03/28 15:44:22]

Ok, fixed here.

 
 // Tells the renderer that this password form is not blacklisted.  A form can
 // be blacklisted if a user chooses "never save passwords for this site".
 IPC_MESSAGE_ROUTED1(AutofillMsg_FormNotBlacklisted,
                     autofill::PasswordForm /* form checked */)
 
 // Sent when requestAutocomplete() finishes (either succesfully or with an
 // error). If it was a success, the renderer fills the form that requested
 // autocomplete with the |form_data| values input by the user.
 IPC_MESSAGE_ROUTED2(AutofillMsg_RequestAutocompleteResult,
@@ skipping 96 matching lines @@
 IPC_MESSAGE_ROUTED4(AutofillHostMsg_ShowPasswordSuggestions,
                     autofill::FormFieldData /* the form field */,
                     gfx::RectF /* input field bounds, window-relative */,
                     std::vector<base::string16> /* suggestions */,
                     std::vector<base::string16> /* realms */)
 
 // Inform browser of data list values for the curent field.
 IPC_MESSAGE_ROUTED2(AutofillHostMsg_SetDataList,
                     std::vector<base::string16> /* values */,
                     std::vector<base::string16> /* labels */)