Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Issue 184103006: Reinstate workarounds for atan2, fmod, pow in MathExtras on vs2013 (Closed)

Created:
6 years, 9 months ago by scottmg
Modified:
6 years, 9 months ago
Reviewers:
jamesr
CC:
blink-reviews, loislo+blink_chromium.org, yurys+blink_chromium.org, abarth-chromium, adamk+blink_chromium.org, Inactive, Mikhail
Visibility:
Public.

Description

Reinstate workarounds for atan2, fmod, pow in MathExtras on vs2013 I incorrectly removed some these workaround functions for VS2013 at https://codereview.chromium.org/27009003 . The other non-workaround functions (that just didn't exist previously) seem to be OK, but the behaviour around +-Inf is still different than we expect for JS and XPath. R=jamesr@chromium.org BUG=347870 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168231

Patch Set 1 #

Patch Set 2 : use numeric_limits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M Source/wtf/MathExtras.h View 4 chunks +12 lines, -1 line 0 comments Download
M Source/wtf/MathExtrasTest.cpp View 1 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
scottmg
6 years, 9 months ago (2014-02-28 18:15:24 UTC) #1
jamesr
can we add unit tests for these math cases in MathExtrasTest.cpp ? since you know ...
6 years, 9 months ago (2014-02-28 23:04:49 UTC) #2
jamesr
lgtm if you pinky swear to add tests for each of these workarounds soon
6 years, 9 months ago (2014-02-28 23:05:08 UTC) #3
scottmg
On 2014/02/28 23:05:08, jamesr wrote: > lgtm if you pinky swear to add tests for ...
6 years, 9 months ago (2014-02-28 23:06:12 UTC) #4
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 9 months ago (2014-02-28 23:06:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/184103006/1
6 years, 9 months ago (2014-02-28 23:06:25 UTC) #6
scottmg
The CQ bit was unchecked by scottmg@chromium.org
6 years, 9 months ago (2014-02-28 23:18:29 UTC) #7
scottmg
nvm, added tests here, ptal
6 years, 9 months ago (2014-02-28 23:19:10 UTC) #8
jamesr
still lgtm. i hope we don't need fuzzy comparisons on these
6 years, 9 months ago (2014-02-28 23:32:06 UTC) #9
scottmg
6 years, 9 months ago (2014-03-01 02:37:43 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 manually as r168231 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698