Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 27009003: Fixes for compilation of Blink on VS2013 (Closed)

Created:
7 years, 2 months ago by scottmg
Modified:
7 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, loislo+blink_chromium.org, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fixes for compilation of Blink on VS2013 - Disable some math functions that are now part of the C runtime - Add missing include of <algorithm> for std::max - Disable optimization of dtoa code on VS2013. Upstream bug filed and fixed for next release. NOTRY=true R=abarth@chromium.org BUG=288948 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159686

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M Source/wtf/MathExtras.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/dtoa.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M public/platform/WebFloatSize.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
scottmg
7 years, 2 months ago (2013-10-11 17:34:30 UTC) #1
abarth-chromium
lgtm
7 years, 2 months ago (2013-10-11 17:37:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/27009003/1
7 years, 2 months ago (2013-10-11 17:37:39 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=10527
7 years, 2 months ago (2013-10-11 22:08:50 UTC) #4
scottmg
On 2013/10/11 22:08:50, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 2 months ago (2013-10-11 22:17:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/27009003/1
7 years, 2 months ago (2013-10-11 22:17:36 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=10570
7 years, 2 months ago (2013-10-12 00:47:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/27009003/1
7 years, 2 months ago (2013-10-12 01:17:16 UTC) #8
abarth-chromium
If this next cq doesn't work, you might just want to send it through with ...
7 years, 2 months ago (2013-10-12 01:17:32 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=10608
7 years, 2 months ago (2013-10-12 02:37:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/27009003/1
7 years, 2 months ago (2013-10-15 17:02:41 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=11391
7 years, 2 months ago (2013-10-15 19:03:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/27009003/1
7 years, 2 months ago (2013-10-15 19:31:19 UTC) #13
commit-bot: I haz the power
7 years, 2 months ago (2013-10-15 19:32:33 UTC) #14
Message was sent while issue was closed. 
Change committed as 159686

Powered by Google App Engine
This is Rietveld 408576698