Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 1840983002: Video Player: Set proper aria-label to the toggle button for subtitles. (Closed)

Created:
4 years, 8 months ago by fukino
Modified:
4 years, 8 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Video Player: Set proper aria-label to the toggle button for subtitles. This CL fixes following problems about aria-label of subtitles button. - VIDEO_PLAYER_SUBTITLES_BUTTON_LABEL was used, but it actually is undefined. - The button has two states since it is toggle button, but it couldn't be distinguished by the aria-label (and spoken feedback) BUG=598613 TEST=manually enable/disable subtitles button and check the aria-label using inspector. Committed: https://crrev.com/bad01e0d4f1de8fde606a30d07739917e4be1e05 Cr-Commit-Position: refs/heads/master@{#383705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/file_manager/video_player/js/media_controls.js View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
fukino
hirono@, could you take a look? Thanks!
4 years, 8 months ago (2016-03-29 09:14:07 UTC) #3
hirono
lgtm, thank you for fixing this!
4 years, 8 months ago (2016-03-29 10:22:53 UTC) #4
fukino
On 2016/03/29 10:22:53, hirono wrote: > lgtm, thank you for fixing this! Thanks!
4 years, 8 months ago (2016-03-29 12:27:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840983002/1
4 years, 8 months ago (2016-03-29 12:27:57 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 12:55:23 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 12:57:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bad01e0d4f1de8fde606a30d07739917e4be1e05
Cr-Commit-Position: refs/heads/master@{#383705}

Powered by Google App Engine
This is Rietveld 408576698