chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc - Issue 1840983002: Video Player: Set proper aria-label to the toggle button for subtitles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc

Issue 1840983002: Video Player: Set proper aria-label to the toggle button for subtitles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc

diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc

index d75d74010f5dcc3dd2329f41a1320e700d3ee99d..9dc745b4cff8447c36d74e9d587820089c929260 100644

--- a/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc

+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc

@@ -242,6 +242,10 @@ void AddStringsForVideoPlayer(base::DictionaryValue* dict) {

IDS_VIDEO_PLAYER_FULL_SCREEN_BUTTON_LABEL);

SET_STRING("VIDEO_PLAYER_EXIT_FULL_SCREEN_BUTTON_LABEL",

IDS_VIDEO_PLAYER_EXIT_FULL_SCREEN_BUTTON_LABEL);

+ SET_STRING("VIDEO_PLAYER_ENABLE_SUBTITLES_BUTTON_LABEL",

+ IDS_VIDEO_PLAYER_ENABLE_SUBTITLES_BUTTON_LABEL);

+ SET_STRING("VIDEO_PLAYER_DISABLE_SUBTITLES_BUTTON_LABEL",

+ IDS_VIDEO_PLAYER_DISABLE_SUBTITLES_BUTTON_LABEL);

}

void AddStringsForAudioPlayer(base::DictionaryValue* dict) {

« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | ui/file_manager/video_player/js/media_controls.js » ('j') | no next file with comments »