Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1840913002: A11y setting: mono audio UI (Closed)

Created:
4 years, 8 months ago by Qiang(Joe) Xu
Modified:
4 years, 8 months ago
Reviewers:
oshima, stevenjb, Mark P, sky
CC:
chromium-reviews, sadrul, asvitkine+watch_chromium.org, michaelpg+watch-md-settings_chromium.org, dmazzoni+watch_chromium.org, aboxhall+watch_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, je_julie, kalyank, jbudorick+watch_chromium.org, dbeam+watch-options_chromium.org, yuzo+watch_chromium.org, michaelpg+watch-md-ui_chromium.org, oshima+watch_chromium.org, michaelpg+watch-options_chromium.org, hashimoto+watch_chromium.org, nektar+watch_chromium.org, mikecase+watch_chromium.org, dtseng+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

A11y setting: mono audio mainly two parts: 1) a11y checkbox 2) dbus method call and an a11y controller class BUG=404701 TEST=accessibility_manager_browsertest.cc Youtube speaker headphones test left and right There is still a bug when playing reverse polarity stereo audio sound, which I will open a bug to track and discuss with cras side members. crbug/598744 Committed: https://crrev.com/533c8f6025861232be19af95fff93faff3b5fdb1 Cr-Commit-Position: refs/heads/master@{#386543}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Merge #

Patch Set 3 : changes in audio_a11y_controller.h(cc). Others are caused from Merge #

Patch Set 4 : Merge #

Patch Set 5 : add monoAudioLabel in md_settings #

Patch Set 6 : Merge #

Patch Set 7 : fix SettingsAdvancedPageBrowserTest.Load browser_test failure #

Total comments: 4

Patch Set 8 : delete tray a11y hand icon view #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -2 lines) Patch
M ash/accessibility_delegate.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/ash_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/default_accessibility_delegate.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ash/default_accessibility_delegate.cc View 2 chunks +10 lines, -1 line 0 comments Download
M ash/shell.h View 1 2 3 4 5 3 chunks +9 lines, -0 lines 0 comments Download
M ash/shell.cc View 1 2 3 4 5 6 7 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/app/chromeos_strings.grdp View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/app/settings_strings.grdp View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.h View 1 2 3 4 5 5 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 2 3 4 5 8 chunks +46 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc View 1 2 3 4 5 20 chunks +83 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/settings_private/prefs_util.cc View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/a11y_page/a11y_page.html View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
A chromeos/audio/audio_a11y_controller.h View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A chromeos/audio/audio_a11y_controller.cc View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
M chromeos/chromeos.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 2 3 4 5 6 7 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 53 (24 generated)
Qiang(Joe) Xu
4 years, 8 months ago (2016-03-29 00:46:35 UTC) #3
stevenjb
https://codereview.chromium.org/1840913002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/1840913002/diff/1/DEPS#newcode390 DEPS:390: Var('chromium_git') + '/chromiumos/platform/system_api.git' + '@' + '452060bb03235f1241f5822f326f2abbc936e656', This should ...
4 years, 8 months ago (2016-03-29 00:54:00 UTC) #4
stevenjb
Could you separate out the DBus support (i.e. the chromeos/ and dbus/ changes) from the ...
4 years, 8 months ago (2016-03-29 01:05:19 UTC) #5
Qiang(Joe) Xu
On 2016/03/29 01:05:19, stevenjb wrote: > Could you separate out the DBus support (i.e. the ...
4 years, 8 months ago (2016-03-29 01:35:10 UTC) #6
Qiang(Joe) Xu
https://codereview.chromium.org/1840913002/diff/1/build/android/test_runner.pydeps File build/android/test_runner.pydeps (left): https://codereview.chromium.org/1840913002/diff/1/build/android/test_runner.pydeps#oldcode138 build/android/test_runner.pydeps:138: pylib/remote/device/remote_device_uirobot_test_run.py On 2016/03/29 01:05:19, stevenjb wrote: > Intentional? If ...
4 years, 8 months ago (2016-03-29 01:36:51 UTC) #7
stevenjb
I would extract the DBus changes into a separate branch / CL, then use 'git ...
4 years, 8 months ago (2016-03-29 01:41:05 UTC) #8
jbudorick
https://codereview.chromium.org/1840913002/diff/1/build/android/test_runner.pydeps File build/android/test_runner.pydeps (left): https://codereview.chromium.org/1840913002/diff/1/build/android/test_runner.pydeps#oldcode138 build/android/test_runner.pydeps:138: pylib/remote/device/remote_device_uirobot_test_run.py On 2016/03/29 01:36:51, Qiang (Joe) Xu wrote: > ...
4 years, 8 months ago (2016-03-29 13:08:20 UTC) #10
agrieve
https://codereview.chromium.org/1840913002/diff/1/build/android/test_runner.pydeps File build/android/test_runner.pydeps (left): https://codereview.chromium.org/1840913002/diff/1/build/android/test_runner.pydeps#oldcode138 build/android/test_runner.pydeps:138: pylib/remote/device/remote_device_uirobot_test_run.py On 2016/03/29 13:08:20, jbudorick wrote: > On 2016/03/29 ...
4 years, 8 months ago (2016-03-29 15:09:56 UTC) #11
Mark P
actions.xml lgtm
4 years, 8 months ago (2016-03-29 16:42:33 UTC) #13
Qiang(Joe) Xu
dbus changes moved in: https://chromium.googlesource.com/chromium/src/+/a377c049175591928ea1507ef76242d913363011 cras_audio_handler changes in: https://chromium.googlesource.com/chromium/src/+/745246282c486ab7a03e40def351a78b7f3958c0 This issue is updated to UI ...
4 years, 8 months ago (2016-03-31 02:02:21 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840913002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840913002/40001
4 years, 8 months ago (2016-04-07 22:26:50 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/193477)
4 years, 8 months ago (2016-04-07 23:52:27 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840913002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840913002/100001
4 years, 8 months ago (2016-04-08 16:40:13 UTC) #25
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/184537) ios_dbg_simulator_gn on ...
4 years, 8 months ago (2016-04-08 16:43:16 UTC) #27
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840913002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840913002/100001
4 years, 8 months ago (2016-04-08 18:15:04 UTC) #29
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/156824) ios_rel_device_gn on ...
4 years, 8 months ago (2016-04-08 18:18:28 UTC) #31
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840913002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840913002/120001
4 years, 8 months ago (2016-04-08 18:42:56 UTC) #33
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/194034)
4 years, 8 months ago (2016-04-08 19:57:25 UTC) #35
stevenjb
chromeos/ lgtm
4 years, 8 months ago (2016-04-08 20:53:43 UTC) #36
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840913002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840913002/140001
4 years, 8 months ago (2016-04-09 00:18:09 UTC) #39
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-09 01:25:47 UTC) #41
Qiang(Joe) Xu
On 2016/04/09 01:25:47, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 8 months ago (2016-04-09 01:40:07 UTC) #42
sky
chrome LGTM I did not look at ash
4 years, 8 months ago (2016-04-11 15:11:08 UTC) #43
oshima
https://codereview.chromium.org/1840913002/diff/140001/ash/shell.cc File ash/shell.cc (right): https://codereview.chromium.org/1840913002/diff/140001/ash/shell.cc#newcode769 ash/shell.cc:769: #endif // defined(OS_CHROMEOS) since you initialized very early on, ...
4 years, 8 months ago (2016-04-11 17:05:30 UTC) #44
Qiang(Joe) Xu
https://codereview.chromium.org/1840913002/diff/140001/ash/shell.cc File ash/shell.cc (right): https://codereview.chromium.org/1840913002/diff/140001/ash/shell.cc#newcode769 ash/shell.cc:769: #endif // defined(OS_CHROMEOS) On 2016/04/11 17:05:30, oshima wrote: > ...
4 years, 8 months ago (2016-04-11 20:59:10 UTC) #45
oshima
ash lgtm
4 years, 8 months ago (2016-04-11 21:03:46 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840913002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840913002/160001
4 years, 8 months ago (2016-04-11 21:30:57 UTC) #49
commit-bot: I haz the power
Committed patchset #8 (id:160001)
4 years, 8 months ago (2016-04-12 01:19:54 UTC) #51
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 01:21:04 UTC) #53
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/533c8f6025861232be19af95fff93faff3b5fdb1
Cr-Commit-Position: refs/heads/master@{#386543}

Powered by Google App Engine
This is Rietveld 408576698