Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2975)

Unified Diff: blimp/client/feature/compositor/blimp_compositor_manager.cc

Issue 1840843005: blimp: Add logging for compositor and render widget feature. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/feature/compositor/blimp_compositor_manager.cc
diff --git a/blimp/client/feature/compositor/blimp_compositor_manager.cc b/blimp/client/feature/compositor/blimp_compositor_manager.cc
index 4e5e67fea276b4c6c378697c7caf0ca01c5a5119..6ebd4d34a541f82b895e0a4607878faacd00ea99 100644
--- a/blimp/client/feature/compositor/blimp_compositor_manager.cc
+++ b/blimp/client/feature/compositor/blimp_compositor_manager.cc
@@ -78,17 +78,23 @@ scoped_ptr<BlimpCompositor> BlimpCompositorManager::CreateBlimpCompositor(
void BlimpCompositorManager::OnRenderWidgetCreated(int render_widget_id) {
DCHECK(!GetCompositor(render_widget_id));
+ VLOG(1) << "Creating Blimp Compositor for render widget: "
+ << render_widget_id;
compositors_[render_widget_id] = CreateBlimpCompositor(render_widget_id,
this);
}
void BlimpCompositorManager::OnRenderWidgetInitialized(int render_widget_id) {
+ VLOG(1) << "Received render widget initialized message for: "
haibinlu 2016/03/30 18:37:08 redundant log given the 2 logs below?
Khushal 2016/03/30 18:55:47 Done.
+ << render_widget_id;
if (active_compositor_ &&
active_compositor_->render_widget_id() == render_widget_id)
return;
if (active_compositor_) {
+ VLOG(1) << "Hiding currently active compositor for render widget: "
+ << active_compositor_->render_widget_id();
active_compositor_->SetVisible(false);
active_compositor_->ReleaseAcceleratedWidget();
}
@@ -96,11 +102,13 @@ void BlimpCompositorManager::OnRenderWidgetInitialized(int render_widget_id) {
active_compositor_ = GetCompositor(render_widget_id);
DCHECK(active_compositor_);
+ VLOG(1) << "Activating compositor for render widget: " << render_widget_id;
active_compositor_->SetVisible(visible_);
active_compositor_->SetAcceleratedWidget(window_);
}
void BlimpCompositorManager::OnRenderWidgetDeleted(int render_widget_id) {
+ VLOG(1) << "Destroying compositor for render widget: " << render_widget_id;
CompositorMap::const_iterator it = compositors_.find(render_widget_id);
DCHECK(it != compositors_.end());
@@ -114,6 +122,8 @@ void BlimpCompositorManager::OnRenderWidgetDeleted(int render_widget_id) {
void BlimpCompositorManager::OnCompositorMessageReceived(
int render_widget_id,
scoped_ptr<cc::proto::CompositorMessage> message) {
+ VLOG(1) << "Compositor message received for render_widget: "
haibinlu 2016/03/30 18:37:08 this is already logged in net layer.
Khushal 2016/03/30 18:55:47 Does it log the render widget id as well?
haibinlu 2016/03/30 19:33:11 No, it does not. but you can add it in common/logg
Khushal 2016/03/31 18:42:04 That's neat. Done.
+ << render_widget_id;
BlimpCompositor* compositor = GetCompositor(render_widget_id);
DCHECK(compositor);
@@ -176,6 +186,7 @@ BlimpCompositorManager::GetImageSerializationProcessor() {
void BlimpCompositorManager::SendWebGestureEvent(
int render_widget_id,
const blink::WebGestureEvent& gesture_event) {
+ VLOG(1) << "Sending input event for render_widget: " << render_widget_id;
haibinlu 2016/03/30 18:37:08 ditto. logged in net layer.
render_widget_feature_->SendWebGestureEvent(kDummyTabId,
render_widget_id,
gesture_event);
@@ -184,6 +195,8 @@ void BlimpCompositorManager::SendWebGestureEvent(
void BlimpCompositorManager::SendCompositorMessage(
int render_widget_id,
const cc::proto::CompositorMessage& message) {
+ VLOG(1) << "Sending compositor message for render_widget: "
haibinlu 2016/03/30 18:37:08 ditto
+ << render_widget_id;
render_widget_feature_->SendCompositorMessage(kDummyTabId,
render_widget_id,
message);

Powered by Google App Engine
This is Rietveld 408576698