blimp: Add logging for compositor and render widget feature.

blimp/client/feature/compositor/blimp_compositor_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/client/feature/compositor/blimp_compositor_manager.h"
 
 #include "base/lazy_instance.h"
 #include "blimp/client/feature/compositor/blimp_layer_tree_settings.h"
 #include "blimp/common/compositor/blimp_image_serialization_processor.h"
 #include "blimp/common/compositor/blimp_task_graph_runner.h"
@@ skipping 60 matching lines @@
 }
 
 scoped_ptr<BlimpCompositor> BlimpCompositorManager::CreateBlimpCompositor(
     int render_widget_id, BlimpCompositorClient* client) {
   return make_scoped_ptr(
       new BlimpCompositor(render_widget_id, client));
 }
 
 void BlimpCompositorManager::OnRenderWidgetCreated(int render_widget_id) {
   DCHECK(!GetCompositor(render_widget_id));
+  VLOG(1) << "Creating Blimp Compositor for render widget: "
+          << render_widget_id;
 
   compositors_[render_widget_id] = CreateBlimpCompositor(render_widget_id,
                                                          this);
 }
 
 void BlimpCompositorManager::OnRenderWidgetInitialized(int render_widget_id) {
+  VLOG(1) << "Received render widget initialized message for: "

[haibinlu, 2016/03/30 18:37:08]

redundant log given the 2 logs below?

[Khushal, 2016/03/30 18:55:47]

Done.

+          << render_widget_id;
   if (active_compositor_ &&
       active_compositor_->render_widget_id() == render_widget_id)
     return;
 
   if (active_compositor_) {
+    VLOG(1) << "Hiding currently active compositor for render widget: "
+            << active_compositor_->render_widget_id();
     active_compositor_->SetVisible(false);
     active_compositor_->ReleaseAcceleratedWidget();
   }
 
   active_compositor_ = GetCompositor(render_widget_id);
   DCHECK(active_compositor_);
 
+  VLOG(1) << "Activating compositor for render widget: " << render_widget_id;
   active_compositor_->SetVisible(visible_);
   active_compositor_->SetAcceleratedWidget(window_);
 }
 
 void BlimpCompositorManager::OnRenderWidgetDeleted(int render_widget_id) {
+  VLOG(1) << "Destroying compositor for render widget: " << render_widget_id;
   CompositorMap::const_iterator it = compositors_.find(render_widget_id);
   DCHECK(it != compositors_.end());
 
   // Reset the |active_compositor_| if that is what we're destroying right now.
   if (active_compositor_ == it->second.get())
     active_compositor_ = nullptr;
 
   compositors_.erase(it);
 }
 
 void BlimpCompositorManager::OnCompositorMessageReceived(
     int render_widget_id,
     scoped_ptr<cc::proto::CompositorMessage> message) {
+  VLOG(1) << "Compositor message received for render_widget: "

[haibinlu, 2016/03/30 18:37:08]

this is already logged in net layer. 

[Khushal, 2016/03/30 18:55:47]

Does it log the render widget id as well?

[haibinlu, 2016/03/30 19:33:11]

No, it does not. but you can add it in common/logging.cc

lass CompositorLogExtractor : public LogExtractor {
  void ExtractFields(const BlimpMessage& message,
                     LogFields* output) const override {
    AddField("render_widget_id", message.compositor().render_widget_id(),
output);
  }
};

[Khushal, 2016/03/31 18:42:04]

That's neat. Done.

+          << render_widget_id;
   BlimpCompositor* compositor = GetCompositor(render_widget_id);
   DCHECK(compositor);
 
   compositor->OnCompositorMessageReceived(std::move(message));
 }
 
 cc::LayerTreeSettings* BlimpCompositorManager::GetLayerTreeSettings() {
   if (!settings_) {
     settings_.reset(new cc::LayerTreeSettings);
 
@@ skipping 42 matching lines @@
 }
 
 cc::ImageSerializationProcessor*
 BlimpCompositorManager::GetImageSerializationProcessor() {
   return image_serialization_processor_.get();
 }
 
 void BlimpCompositorManager::SendWebGestureEvent(
     int render_widget_id,
     const blink::WebGestureEvent& gesture_event) {
+  VLOG(1) << "Sending input event for render_widget: " << render_widget_id;

[haibinlu, 2016/03/30 18:37:08]

ditto. logged in net layer.

   render_widget_feature_->SendWebGestureEvent(kDummyTabId,
                                              render_widget_id,
                                              gesture_event);
 }
 
 void BlimpCompositorManager::SendCompositorMessage(
     int render_widget_id,
     const cc::proto::CompositorMessage& message) {
+  VLOG(1) << "Sending compositor message for render_widget: "

[haibinlu, 2016/03/30 18:37:08]

ditto

+          << render_widget_id;
   render_widget_feature_->SendCompositorMessage(kDummyTabId,
                                                render_widget_id,
                                                message);
 }
 
 BlimpCompositor* BlimpCompositorManager::GetCompositor(int render_widget_id) {
   CompositorMap::const_iterator it = compositors_.find(render_widget_id);
   if (it == compositors_.end())
     return nullptr;
   return it->second.get();
 }
 
 }  // namespace client
 }  // namespace blimp