Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 1840663002: Temporary fix for --preAbandonGpuContext bug (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org, djsollen
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Temporary fix for --preAbandonGpuContext bug In this instance what is going wrong is: the context gets abandoned SkCanvas tries to create a new SkGpuDevice (which fails) if then creates a bitmap device it then attempts to draw the abandoned GrTexture (behind the old SkGpuDevice into the new bitmap device with an image filter b.c. some image filters still switch their behavior based on the presence of a texture bad stuff happens This used to be resolved by the new bitmap device getting forced down the bitmap path and then failing when it attempted to readback the GrTexture. BUG=skia:5138 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1840663002 Committed: https://skia.googlesource.com/skia/+/090b7629daa4d2ed13424d21e93f0ff0c4886ba9

Patch Set 1 #

Patch Set 2 : Temporary fix for --preAbandonGpuContext bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M src/core/SkSpecialImage.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
robertphillips
4 years, 8 months ago (2016-03-28 16:36:35 UTC) #5
bsalomon
lgtm
4 years, 8 months ago (2016-03-28 17:10:27 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840663002/20001
4 years, 8 months ago (2016-03-28 17:13:43 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-28 17:23:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840663002/20001
4 years, 8 months ago (2016-03-28 18:06:50 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 18:07:47 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/090b7629daa4d2ed13424d21e93f0ff0c4886ba9

Powered by Google App Engine
This is Rietveld 408576698