Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1840603002: Remove symlinks to external files. (Closed)

Created:
4 years, 9 months ago by dnj
Modified:
4 years, 8 months ago
Reviewers:
Vadim Sh., iannucci, nodir
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
D appengine/cmd/helloworld/gae.py View 1 chunk +0 lines, -1 line 0 comments Download
D appengine/cmd/helloworld_mvm/gae.py View 1 chunk +0 lines, -1 line 0 comments Download
D appengine/cmd/tokenserver/gae.py View 1 chunk +0 lines, -1 line 0 comments Download
D common/prpc/talk/buildbot/gae.py View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Issue 1834123002 Patch 1

Messages

Total messages: 7 (3 generated)
dnj
PTAL. This removes (as far as I could scan) all symlinks to files outside of ...
4 years, 9 months ago (2016-03-26 15:56:01 UTC) #2
Vadim Sh.
lgtm
4 years, 9 months ago (2016-03-27 20:57:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840603002/1
4 years, 8 months ago (2016-03-28 18:52:52 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 18:55:46 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/19b02eceea8c04a342c88d6e8a5bf563f5e13fb3

Powered by Google App Engine
This is Rietveld 408576698