Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1834123002: common/recordio: Add zero-copy buffer split. (Closed)

Created:
4 years, 9 months ago by dnj
Modified:
4 years, 8 months ago
Reviewers:
estaab, iannucci
CC:
andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii+luci-go_chromium.org, todd
Base URL:
https://github.com/luci/luci-go@symlink-clean
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

common/recordio: Add zero-copy buffer split. BUG=chromium:597886 TEST=None Committed: https://github.com/luci/luci-go/commit/b94ad2af8d4ab2dc17e79980e341f966c3439ed1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
M common/recordio/reader.go View 2 chunks +33 lines, -0 lines 0 comments Download
M common/recordio/reader_test.go View 3 chunks +49 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1840603002 Patch 1

Dependent Patchsets:

Issue 1838803002 Patch 1

Messages

Total messages: 7 (3 generated)
dnj
PTAL
4 years, 8 months ago (2016-03-28 15:24:40 UTC) #2
estaab
lgtm
4 years, 8 months ago (2016-03-29 02:26:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834123002/1
4 years, 8 months ago (2016-03-29 17:14:53 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 17:18:31 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/b94ad2af8d4ab2dc17e79980e341f966c3439ed1

Powered by Google App Engine
This is Rietveld 408576698