Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1840553002: Revert of Turn on seamless cubemap by default on Desktop GL for ES3. (Closed)

Created:
4 years, 9 months ago by Zhenyao Mo
Modified:
4 years, 9 months ago
Reviewers:
Antoine Labour, piman
CC:
chromium-reviews, piman+watch_chromium.org, Ken Russell (switch to Gerrit), bajones
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Turn on seamless cubemap by default on Desktop GL for ES3. (patchset #3 id:40001 of https://codereview.chromium.org/1831833006/ ) Reason for revert: This doesn't work on Mac Intel (most likely a driver bug) Original issue's description: > Turn on seamless cubemap by default on Desktop GL for ES3. > > BUG=597794 > TEST=deqp/texturefiltering_cube_* > R=piman@chromium.org > CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/39a22dc8028987efa3ca24135922841d2d2d387c > Cr-Commit-Position: refs/heads/master@{#383362} TBR=piman@chromium.org,piman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=597794 Committed: https://crrev.com/0e22e7e8fe94d4f4deadcb2d6460e6a1ca38cd35 Cr-Commit-Position: refs/heads/master@{#383405}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Zhenyao Mo
Created Revert of Turn on seamless cubemap by default on Desktop GL for ES3.
4 years, 9 months ago (2016-03-25 23:33:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840553002/1
4 years, 9 months ago (2016-03-25 23:34:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-25 23:34:57 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 23:36:04 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e22e7e8fe94d4f4deadcb2d6460e6a1ca38cd35
Cr-Commit-Position: refs/heads/master@{#383405}

Powered by Google App Engine
This is Rietveld 408576698