Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5330)

Unified Diff: chrome/android/java/strings/android_chrome_strings.grd

Issue 1840513002: Redesign sign in and sign in confirmation screens for Narnia 2.0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/strings/android_chrome_strings.grd
diff --git a/chrome/android/java/strings/android_chrome_strings.grd b/chrome/android/java/strings/android_chrome_strings.grd
index b43642954c23c67be23906abf361687f0ba55e0a..722720010b38c300e189bc7b46e6e8843ebc80ef 100644
--- a/chrome/android/java/strings/android_chrome_strings.grd
+++ b/chrome/android/java/strings/android_chrome_strings.grd
@@ -1670,24 +1670,24 @@ You are signing in with a managed account and giving its administrator control o
<message name="IDS_MAKE_CHROME_YOURS" desc="Title for the signin promo that prompts the user to sign in to Chrome to have a personalized experirence. [CHAR-LIMIT=24]">
Make Chrome yours
</message>
- <message name="IDS_SIGNIN_NO_ACCOUNT_CHOICE_DESCRIPTION" desc="Text for account chooser page when there are no accounts on the device.">
- Add an account to get your bookmarks, history, passwords, and other settings on all your devices.
- </message>
- <message name="IDS_SIGNIN_SIGN_IN_TO_CHROME_SUMMARY_VARIANT" desc="A variant of summary for the signin promo; lists reasons to sign in to Chrome.">
- Sign in to access all your web stuff from any device
- </message>
<message name="IDS_SIGNIN_HI_NAME" desc="Title welcoming the user by their name after they have signed in.">
Hi, <ph name="FULL_NAME">%1$s<ex>John Smith</ex></ph>
</message>
+ <message name="IDS_SIGNIN_SIGNED_IN_DESCRIPTION_TITLE" desc="The title of showing explanation of what gets synced after the user signed in">
newt (away) 2016/04/01 23:43:12 "The title of the explanation..."
gogerald1 2016/04/12 01:21:13 Done. use cross platform string.
+ Chrome Sync
Bernhard Bauer 2016/04/04 16:09:16 BTW, these strings already exist in chrome/app/gen
gogerald1 2016/04/12 01:21:13 Done.use cross platform string.
+ </message>
<message name="IDS_SIGNIN_SIGNED_IN_DESCRIPTION" desc="Explanation of what gets synced after the user signed in">
Your bookmarks, history, passwords, and other settings will be synced to your Google Account so you can use them on all your devices. You can choose what to sync in <ph name="BEGIN_LINK1">&lt;LINK1&gt;</ph>Settings<ph name="END_LINK1">&lt;/LINK1&gt;</ph>.
</message>
<message name="IDS_SIGNIN_SIGNED_IN_DESCRIPTION_UCA_ADDENDUM" desc="Additional explanation for child accounts that synced settings are managed by parents.">
Your parents help manage these settings.
</message>
- <message name="IDS_ACCESSIBILITY_SIGNIN_ACCOUNT_SPINNER" desc="Content description for the first run account drop down spinner.">
- Choose account
+ <message name ="IDS_PERSONALIZE_GOOGLE_SERVICE" desc="Content description for the sign in confirmation to option in personalize google services">
newt (away) 2016/04/01 23:43:12 This is not a "content description" (i.e. the text
newt (away) 2016/04/01 23:43:12 s/name =/name=/
gogerald1 2016/04/12 01:21:13 Done.use cross platform string.
gogerald1 2016/04/12 01:21:13 Done.
+ Personalize Google services
</message>
+ <message name ="IDS_OPEN_MYACCOUNT_AFTER_SIGN_IN" desc="Description in sign in confirmation to allow user choose to open myaccount.google.com after sign in">
+ Open myaccount.google.com after signing in
newt (away) 2016/04/01 23:43:12 Put myaccount.google.com inside a placeholder tag
gogerald1 2016/04/12 01:21:13 Done.use cross platform string.
+ </message>
<!-- External Navigation Strings -->
<message name="IDS_EXTERNAL_APP_LEAVE_INCOGNITO_WARNING" desc="Alert dialog text warning that user that incognito mode does not continue into external apps.">

Powered by Google App Engine
This is Rietveld 408576698