new strings for Sync Confirmation screen

new strings Sync Confirmation screen

These strings will be used in the enhanced Sync Confirmation screen.

We're landing these strings now because 3 engineers are working on this in parallel on different platforms.

Committed: https://crrev.com/4646679d35fcf63a03155e8a454df099a74d2788
Cr-Commit-Position: refs/heads/master@{#382075}

[Moe, 2016-03-16 18:06:32]

mahmadi@chromium.org changed reviewers:
+ anthonyvd@chromium.org, rogerta@chromium.org

[anthonyvd, 2016-03-16 18:16:30]

lgtm

Maybe explain what those strings will be used for and where they come from in
the description.

For the record, we're landing those strings now because we have 3 engineers
working on this in parallel on different platforms.

[Moe, 2016-03-16 18:26:51]

Description was changed from

==========
new Sync Confirmation Modal strings
==========

to

==========
new strings Sync Confirmation screen

These strings will be used in the enhanced Sync Confirmation screen.

We're landing these strings now because 3 engineers are working on this in
parallel on different platforms.
==========

[Moe, 2016-03-16 18:28:26]

mahmadi@chromium.org changed reviewers:
+ estade@chromium.org

[Evan Stade, 2016-03-16 21:58:49]

https://codereview.chromium.org/1805633003/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1805633003/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:10807: +        Chrome Sync
do we call it Chrome Sync even in Chromium?

[Moe, 2016-03-17 21:04:03]

https://codereview.chromium.org/1805633003/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1805633003/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:10807: +        Chrome Sync
On 2016/03/16 21:58:49, Evan Stade wrote:
> do we call it Chrome Sync even in Chromium?

Good point. Checked with the Sync team. It is ok for it "Chrome Sync" even in
Chromium.

[Evan Stade, 2016-03-17 21:07:16]

lgtm

[Moe, 2016-03-17 21:08:43]

The CQ bit was checked by mahmadi@chromium.org

[commit-bot: I haz the power, 2016-03-17 21:09:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805633003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805633003/1

[commit-bot: I haz the power, 2016-03-17 23:30:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 23:30:53]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Moe, 2016-03-18 20:36:30]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2016-03-18 20:36:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
anthonyvd@chromium.org, estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1805633003/#ps20001
(title: "Minor language tweak")

[commit-bot: I haz the power, 2016-03-18 20:36:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805633003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805633003/20001

[commit-bot: I haz the power, 2016-03-18 20:43:05]

Description was changed from

==========
new strings Sync Confirmation screen

These strings will be used in the enhanced Sync Confirmation screen.

We're landing these strings now because 3 engineers are working on this in
parallel on different platforms.
==========

to

==========
new strings Sync Confirmation screen

These strings will be used in the enhanced Sync Confirmation screen.

We're landing these strings now because 3 engineers are working on this in
parallel on different platforms.
==========

[commit-bot: I haz the power, 2016-03-18 20:43:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-18 20:44:42]

Description was changed from

==========
new strings Sync Confirmation screen

These strings will be used in the enhanced Sync Confirmation screen.

We're landing these strings now because 3 engineers are working on this in
parallel on different platforms.
==========

to

==========
new strings Sync Confirmation screen

These strings will be used in the enhanced Sync Confirmation screen.

We're landing these strings now because 3 engineers are working on this in
parallel on different platforms.

Committed: https://crrev.com/4646679d35fcf63a03155e8a454df099a74d2788
Cr-Commit-Position: refs/heads/master@{#382075}
==========

[commit-bot: I haz the power, 2016-03-18 20:44:43]

Patchset 2 (id:??) landed as
https://crrev.com/4646679d35fcf63a03155e8a454df099a74d2788
Cr-Commit-Position: refs/heads/master@{#382075}