Redesign sign in and sign in confirmation screens for Narnia 2.0

chrome/android/java/res/layout/account_signin_account_view.xml

Index: chrome/android/java/res/layout/account_signin_account_view.xml
diff --git a/chrome/android/java/res/layout/account_signin_account_view.xml b/chrome/android/java/res/layout/account_signin_account_view.xml
new file mode 100644
index 0000000000000000000000000000000000000000..3f342232dddda3dcc9961e0299459ac93e598e20
--- /dev/null
+++ b/chrome/android/java/res/layout/account_signin_account_view.xml
@@ -0,0 +1,46 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file.
+-->
+<LinearLayout

[newt (away), 2016/04/01 23:43:10]

nit: use 4-space indentation, instead of 8-space indentation

[gogerald1, 2016/04/12 01:21:11]

Done.

+	xmlns:android="http://schemas.android.com/apk/res/android"
+	android:layout_width="match_parent"
+	android:layout_height="wrap_content"
+	android:layout_gravity="start"

[newt (away), 2016/04/01 23:43:10]

layout_gravity determines how this view is positioned within its parent. gravity
determines how the children are positioned within this view. Why / do you need
this? (I don't think you do.)

[gogerald1, 2016/04/12 01:21:11]

Done.

+	android:orientation="horizontal">
+
+	<ImageView
+		android:id="@+id/account_image"
+		android:layout_width="40dp"
+		android:layout_height="56dp"
+		android:layout_marginEnd="16dp"
+		android:paddingTop="8dp"

[newt (away), 2016/04/01 23:43:10]

suggestion: use marginTop/Bottom instead of paddingTop/Bottom for consistency
with marginEnd. That'll also make the width and height of the image clearer
(currently to get the width of the image you need to subtract 8dp and 8dp from
56dp).

[gogerald1, 2016/04/12 01:21:10]

Done.

+		android:paddingBottom="8dp"
+		android:contentDescription="@null"/>
+	
+	<TextView
+		android:id="@+id/account_name"
+		android:layout_width="wrap_content"
+		android:layout_height="56dp"
+		android:gravity="center"

[newt (away), 2016/04/01 23:43:10]

for clarity, I'd use "center_vertical" instead of "center"

[gogerald1, 2016/04/12 01:21:11]

Done.

+		android:textColor="@color/default_text_color"
+		android:textSize="@dimen/fre_normal_text_size"/>
+
+	<View

[newt (away), 2016/04/01 23:43:10]

This view isn't needed. Instead, just set layout_weight="1" on the account_name
view (and set layout_width="0dp" on the account_name to avoid layout
inefficiencies; see InefficientWeight in the list of Android lint checks:
http://tools.android.com/tips/lint-checks)

Currently, if the TextView takes up too much space, the checkbox won't even be
shown. Moving layout_weight="1" to the TextView will fix this issue.

[gogerald1, 2016/04/12 01:21:11]

Done.

+		android:layout_width="0dp"
+		android:layout_height="0dp"
+		android:layout_weight="1"
+		android:visibility="invisible"/>
+
+	<ImageView

[newt (away), 2016/04/01 23:43:10]

You probably want paddingStart="16dp" in case the account email is long (or the
device is small) and runs into the checkbox.

[gogerald1, 2016/04/12 01:21:10]

Done.

+		android:id="@+id/account_selection_mark"
+		android:layout_width="24dp"
+		android:layout_height="56dp"
+		android:paddingTop="16dp"

[newt (away), 2016/04/01 23:43:10]

similarly, use marginTop/Bottom here

[gogerald1, 2016/04/12 01:21:11]

Done.

+		android:paddingBottom="16dp"
+		android:src="@drawable/bookmark_check_blue"
+		android:visibility="gone"
+		android:contentDescription="@null"/>
+</LinearLayout>