chrome/android/java/res/layout/account_signin_account_view.xml - Issue 1840513002: Redesign sign in and sign in confirmation screens for Narnia 2.0

Side by Side Diff: chrome/android/java/res/layout/account_signin_account_view.xml

Issue 1840513002: Redesign sign in and sign in confirmation screens for Narnia 2.0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/AndroidManifest.xml ('K') | « chrome/android/java/res/drawable-xxxhdpi/personalize_google_service_logo.png ('k') | chrome/android/java/res/layout/account_signin_choice_description_view.xml » ('j') | chrome/android/java/res/layout/account_signin_choice_description_view.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3

	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7 <LinearLayout
	newt (away) 2016/04/01 23:43:10 nit: use 4-space indentation, instead of 8-space i nit: use 4-space indentation, instead of 8-space indentation gogerald1 2016/04/12 01:21:11 Done. Show quoted text On 2016/04/01 23:43:10, newt wrote: > nit: use 4-space indentation, instead of 8-space indentation Done.
	8 xmlns:android="http://schemas.android.com/apk/res/android"

	9 android:layout_width="match_parent"

	10 android:layout_height="wrap_content"

	11 android:layout_gravity="start"
	newt (away) 2016/04/01 23:43:10 layout_gravity determines how this view is positio layout_gravity determines how this view is positioned within its parent. gravity determines how the children are positioned within this view. Why / do you need this? (I don't think you do.) gogerald1 2016/04/12 01:21:11 Done. Show quoted text On 2016/04/01 23:43:10, newt wrote: > layout_gravity determines how this view is positioned within its parent. gravity > determines how the children are positioned within this view. Why / do you need > this? (I don't think you do.) Done.
	12 android:orientation="horizontal">

	13

	14 <ImageView

	15 android:id="@+id/account_image"

	16 android:layout_width="40dp"

	17 android:layout_height="56dp"

	18 android:layout_marginEnd="16dp"

	19 android:paddingTop="8dp"
	newt (away) 2016/04/01 23:43:10 suggestion: use marginTop/Bottom instead of paddin suggestion: use marginTop/Bottom instead of paddingTop/Bottom for consistency with marginEnd. That'll also make the width and height of the image clearer (currently to get the width of the image you need to subtract 8dp and 8dp from 56dp). gogerald1 2016/04/12 01:21:10 Done. Show quoted text On 2016/04/01 23:43:10, newt wrote: > suggestion: use marginTop/Bottom instead of paddingTop/Bottom for consistency > with marginEnd. That'll also make the width and height of the image clearer > (currently to get the width of the image you need to subtract 8dp and 8dp from > 56dp). Done.
	20 android:paddingBottom="8dp"

	21 android:contentDescription="@null"/>

	22

	23 <TextView

	24 android:id="@+id/account_name"

	25 android:layout_width="wrap_content"

	26 android:layout_height="56dp"

	27 android:gravity="center"
	newt (away) 2016/04/01 23:43:10 for clarity, I'd use "center_vertical" instead of for clarity, I'd use "center_vertical" instead of "center" gogerald1 2016/04/12 01:21:11 Done. Show quoted text On 2016/04/01 23:43:10, newt wrote: > for clarity, I'd use "center_vertical" instead of "center" Done.
	28 android:textColor="@color/default_text_color"

	29 android:textSize="@dimen/fre_normal_text_size"/>

	30

	31 <View
	newt (away) 2016/04/01 23:43:10 This view isn't needed. Instead, just set layout_w This view isn't needed. Instead, just set layout_weight="1" on the account_name view (and set layout_width="0dp" on the account_name to avoid layout inefficiencies; see InefficientWeight in the list of Android lint checks: http://tools.android.com/tips/lint-checks) Currently, if the TextView takes up too much space, the checkbox won't even be shown. Moving layout_weight="1" to the TextView will fix this issue. gogerald1 2016/04/12 01:21:11 Done. Show quoted text On 2016/04/01 23:43:10, newt wrote: > This view isn't needed. Instead, just set layout_weight="1" on the account_name > view (and set layout_width="0dp" on the account_name to avoid layout > inefficiencies; see InefficientWeight in the list of Android lint checks: > http://tools.android.com/tips/lint-checks) > > Currently, if the TextView takes up too much space, the checkbox won't even be > shown. Moving layout_weight="1" to the TextView will fix this issue. Done.
	32 android:layout_width="0dp"

	33 android:layout_height="0dp"

	34 android:layout_weight="1"

	35 android:visibility="invisible"/>

	36

	37 <ImageView
	newt (away) 2016/04/01 23:43:10 You probably want paddingStart="16dp" in case the You probably want paddingStart="16dp" in case the account email is long (or the device is small) and runs into the checkbox. gogerald1 2016/04/12 01:21:10 Done. Show quoted text On 2016/04/01 23:43:10, newt wrote: > You probably want paddingStart="16dp" in case the account email is long (or the > device is small) and runs into the checkbox. Done.
	38 android:id="@+id/account_selection_mark"

	39 android:layout_width="24dp"

	40 android:layout_height="56dp"

	41 android:paddingTop="16dp"
	newt (away) 2016/04/01 23:43:10 similarly, use marginTop/Bottom here similarly, use marginTop/Bottom here gogerald1 2016/04/12 01:21:11 Done. Show quoted text On 2016/04/01 23:43:10, newt wrote: > similarly, use marginTop/Bottom here Done.
	42 android:paddingBottom="16dp"

	43 android:src="@drawable/bookmark_check_blue"

	44 android:visibility="gone"

	45 android:contentDescription="@null"/>

	46 </LinearLayout>

OLD	NEW