Source/core/rendering/RenderBox.cpp - Issue 184043033: Remove obsolete FIXME that no longer applies for blink rendering architecture

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.cpp

Issue 184043033: Remove obsolete FIXME that no longer applies for blink rendering architecture (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add new expectations for mac and windows Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/platform/win/fast/repaint/positioned-document-element-expected.txt ('k') | Source/core/rendering/RenderView.cpp » ('j') | Source/core/rendering/RenderView.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBox.cpp

diff --git a/Source/core/rendering/RenderBox.cpp b/Source/core/rendering/RenderBox.cpp

index 760eab0aad7d7832b5fed5c1e2a2aff48cfc7088..ed7f4042dc6dd780c1e9fb0c06dcfa97afd3680d 100644

--- a/Source/core/rendering/RenderBox.cpp

+++ b/Source/core/rendering/RenderBox.cpp

@@ -2042,7 +2042,7 @@ void RenderBox::computeRectForRepaint(const RenderLayerModelObject* repaintConta

rect.moveBy(location());

rect.move(layoutState->m_paintOffset);

- if (layoutState->m_clipped)

+ if (layoutState->m_clipped && !rect.isEmpty())

eseidel 2014/03/11 18:24:30 I'm surprised this is necessary? Doesn't rect.int

rect.intersect(layoutState->m_clipRect);

return;

}