Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: Source/core/rendering/RenderBox.cpp

Issue 184043033: Remove obsolete FIXME that no longer applies for blink rendering architecture (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add new expectations for mac and windows Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 2024 matching lines...) Expand 10 before | Expand all | Expand 10 after
2035 2035
2036 if (layer() && layer()->transform()) 2036 if (layer() && layer()->transform())
2037 rect = layer()->transform()->mapRect(pixelSnappedIntRect(rect)); 2037 rect = layer()->transform()->mapRect(pixelSnappedIntRect(rect));
2038 2038
2039 // We can't trust the bits on RenderObject, because this might be ca lled while re-resolving style. 2039 // We can't trust the bits on RenderObject, because this might be ca lled while re-resolving style.
2040 if (styleToUse->hasInFlowPosition() && layer()) 2040 if (styleToUse->hasInFlowPosition() && layer())
2041 rect.move(layer()->offsetForInFlowPosition()); 2041 rect.move(layer()->offsetForInFlowPosition());
2042 2042
2043 rect.moveBy(location()); 2043 rect.moveBy(location());
2044 rect.move(layoutState->m_paintOffset); 2044 rect.move(layoutState->m_paintOffset);
2045 if (layoutState->m_clipped) 2045 if (layoutState->m_clipped && !rect.isEmpty())
eseidel 2014/03/11 18:24:30 I'm surprised this is necessary? Doesn't rect.int
2046 rect.intersect(layoutState->m_clipRect); 2046 rect.intersect(layoutState->m_clipRect);
2047 return; 2047 return;
2048 } 2048 }
2049 } 2049 }
2050 2050
2051 if (hasReflection()) 2051 if (hasReflection())
2052 rect.unite(reflectedRect(rect)); 2052 rect.unite(reflectedRect(rect));
2053 2053
2054 if (repaintContainer == this) { 2054 if (repaintContainer == this) {
2055 if (repaintContainer->style()->isFlippedBlocksWritingMode()) 2055 if (repaintContainer->style()->isFlippedBlocksWritingMode())
(...skipping 2636 matching lines...) Expand 10 before | Expand all | Expand 10 after
4692 return 0; 4692 return 0;
4693 4693
4694 if (!layoutState && !flowThreadContainingBlock()) 4694 if (!layoutState && !flowThreadContainingBlock())
4695 return 0; 4695 return 0;
4696 4696
4697 RenderBlock* containerBlock = containingBlock(); 4697 RenderBlock* containerBlock = containingBlock();
4698 return containerBlock->offsetFromLogicalTopOfFirstPage() + logicalTop(); 4698 return containerBlock->offsetFromLogicalTopOfFirstPage() + logicalTop();
4699 } 4699 }
4700 4700
4701 } // namespace WebCore 4701 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698