Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3838)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 184043024: Limit scope of settings API configuration and proxy permission (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed Bernhard's comment Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index 5fbee8fbb2dafe5f6a1e9cfd993dd84588663dc7..1932f12ec05266fa134d939a05a8db150dffd52e 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -231,9 +231,8 @@ base::DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
registry->terminated_extensions().Contains(extension->id()));
extension_data->SetBoolean("enabledIncognito",
util::IsIncognitoEnabled(extension->id(), extension_service_->profile()));
- extension_data->SetBoolean("incognitoCanBeToggled",
- extension->can_be_incognito_enabled() &&
- !extension->force_incognito_enabled());
+ extension_data->SetBoolean("incognitoCanBeEnabled",
+ extension->can_be_incognito_enabled());
extension_data->SetBoolean("wantsFileAccess", extension->wants_file_access());
extension_data->SetBoolean("allowFileAccess",
util::AllowFileAccess(extension->id(), extension_service_->profile()));

Powered by Google App Engine
This is Rietveld 408576698