Limit scope of settings API configuration and proxy permission

chrome/browser/extensions/api/preference/preference_api.cc

Index: chrome/browser/extensions/api/preference/preference_api.cc
diff --git a/chrome/browser/extensions/api/preference/preference_api.cc b/chrome/browser/extensions/api/preference/preference_api.cc
index 93f1c97ad1ebc40b998a60d5009c539d40001cd8..3c30a1dff53d665023767125973f6231e313affe 100644
--- a/chrome/browser/extensions/api/preference/preference_api.cc
+++ b/chrome/browser/extensions/api/preference/preference_api.cc
@@ -453,7 +453,9 @@ void PreferenceAPI::InitExtensionControlledPrefs(
        extension_id != extension_ids.end(); ++extension_id) {
     base::Time install_time = prefs->GetInstallTime(*extension_id);
     bool is_enabled = !prefs->IsExtensionDisabled(*extension_id);
-    value_map->RegisterExtension(*extension_id, install_time, is_enabled);
+    bool is_incognito_enabled = prefs->IsIncognitoEnabled(*extension_id);

[not at google - send to devlin, 2014/03/05 17:14:06]

Perhaps you should be using util::IsIncognitoEnabled:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...

[battre, 2014/03/05 17:38:43]

Please take a look at the first version of this CL to see how I tried and failed
with this.

+    value_map->RegisterExtension(
+        *extension_id, install_time, is_enabled, is_incognito_enabled);
     prefs->content_settings_store()->RegisterExtension(
         *extension_id, install_time, is_enabled);