Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 184043004: DevTools: specify trace event filter when installing trace callback (Closed)

Created:
6 years, 9 months ago by caseq
Modified:
6 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, jamesr, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: specify trace event filter when installing trace callback BUG= R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168265

Patch Set 1 #

Patch Set 2 : unsetTraceEventHandler -> resetTraceEventHandler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -10 lines) Patch
M Source/core/inspector/InspectorClient.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/inspector/TraceEventDispatcher.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download
M Source/web/InspectorClientImpl.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/web/InspectorClientImpl.cpp View 1 1 chunk +8 lines, -2 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 1 chunk +7 lines, -2 lines 0 comments Download
M public/web/WebDevToolsAgentClient.h View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
caseq
This depends on chromium counterpart: https://codereview.chromium.org/184283003/
6 years, 9 months ago (2014-02-28 08:46:27 UTC) #1
pfeldman
lgtm
6 years, 9 months ago (2014-02-28 09:23:35 UTC) #2
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 9 months ago (2014-03-02 12:54:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/184043004/20001
6 years, 9 months ago (2014-03-02 12:54:43 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-02 16:30:49 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=14813
6 years, 9 months ago (2014-03-02 16:30:50 UTC) #6
caseq
6 years, 9 months ago (2014-03-03 06:16:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r168265 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698