Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: Source/core/inspector/TraceEventDispatcher.cpp

Issue 184043004: DevTools: specify trace event filter when installing trace callback (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: unsetTraceEventHandler -> resetTraceEventHandler Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorClient.h ('k') | Source/web/InspectorClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/TraceEventDispatcher.cpp
diff --git a/Source/core/inspector/TraceEventDispatcher.cpp b/Source/core/inspector/TraceEventDispatcher.cpp
index a75f4a44cfd9bcdae27a0a6d3dd00b61541f2cfc..e13c87dd9aa48be36c8887d551ff0a08dd9c1869 100644
--- a/Source/core/inspector/TraceEventDispatcher.cpp
+++ b/Source/core/inspector/TraceEventDispatcher.cpp
@@ -100,10 +100,12 @@ void TraceEventDispatcher::processBackgroundEvents()
void TraceEventDispatcher::innerAddListener(const char* name, char phase, TraceEventTargetBase* instance, TraceEventHandlerMethod method, InspectorClient* client)
{
+ static const char CategoryFilter[] = "devtools,webkit";
+
ASSERT(isMainThread());
MutexLocker locker(m_mutex);
if (m_handlers.isEmpty())
- client->setTraceEventCallback(dispatchEventOnAnyThread);
+ client->setTraceEventCallback(CategoryFilter, dispatchEventOnAnyThread);
HandlersMap::iterator it = m_handlers.find(std::make_pair(name, phase));
if (it == m_handlers.end())
m_handlers.add(std::make_pair(name, phase), Vector<BoundTraceEventHandler>()).storedValue->value.append(BoundTraceEventHandler(instance, method));
@@ -133,7 +135,7 @@ void TraceEventDispatcher::removeAllListeners(TraceEventTargetBase* instance, In
m_handlers.swap(remainingHandlers);
}
if (m_handlers.isEmpty())
- client->setTraceEventCallback(0);
+ client->resetTraceEventCallback();
}
size_t TraceEventDispatcher::TraceEvent::findParameter(const char* name) const
« no previous file with comments | « Source/core/inspector/InspectorClient.h ('k') | Source/web/InspectorClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698