Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: third_party/WebKit/LayoutTests/media/track/track-constants.html

Issue 1840393002: Convert track-constants.html from video-test.js to testharness.js based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/track/track-constants-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/media/track/track-constants.html
diff --git a/third_party/WebKit/LayoutTests/media/track/track-constants.html b/third_party/WebKit/LayoutTests/media/track/track-constants.html
index 76078704424495cc5aef5a3385cc88674825f632..2c17f9413e9ec8de14353919226377b89ff09a4f 100644
--- a/third_party/WebKit/LayoutTests/media/track/track-constants.html
+++ b/third_party/WebKit/LayoutTests/media/track/track-constants.html
@@ -1,22 +1,12 @@
<!DOCTYPE html>
-<html>
-<head>
- <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956
- (Please avoid writing new tests using video-test.js) -->
- <script src=../video-test.js></script>
- <script type="text/javascript">
- function doTest ()
- {
- testExpected("HTMLTrackElement.NONE", 0);
- testExpected("HTMLTrackElement.LOADING", 1);
- testExpected("HTMLTrackElement.LOADED", 2);
- testExpected("HTMLTrackElement.ERROR", 3);
-
- endTest();
- }
- </script>
-</head>
-<body onload="doTest()">
- <p>Test TextTrack constants.</p>
-</body>
-</html>
+<title>Test TextTrack constants</title>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+<script type="text/javascript">
philipj_slow 2016/04/01 09:55:07 You can drop the type attribute.
Srirama 2016/04/01 10:05:52 Done.
+test(function() {
+ assert_equals(HTMLTrackElement.NONE, 0);
+ assert_equals(HTMLTrackElement.LOADING, 1);
+ assert_equals(HTMLTrackElement.LOADED, 2);
+ assert_equals(HTMLTrackElement.ERROR, 3);
+});
mlamouri (slow - plz ping) 2016/03/31 10:19:48 Could you add a test description?
Srirama 2016/03/31 10:28:54 I have added the title above, do you prefer descri
philipj_slow 2016/04/01 09:55:07 Having it in the <title> is the simplest way to do
Srirama 2016/04/01 10:05:52 Acknowledged.
+</script>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/track/track-constants-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698