third_party/WebKit/LayoutTests/media/track/track-constants.html - Issue 1840393002: Convert track-constants.html from video-test.js to testharness.js based

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-constants.html

Issue 1840393002: Convert track-constants.html from video-test.js to testharness.js based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <title>Test TextTrack constants</title>

3 <head>	3 <script src="../../resources/testharness.js"></script>

4 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	4 <script src="../../resources/testharnessreport.js"></script>

5 (Please avoid writing new tests using video-test.js) -->	5 <script type="text/javascript">
	philipj_slow 2016/04/01 09:55:07 You can drop the type attribute. You can drop the type attribute. Srirama 2016/04/01 10:05:52 Done. Show quoted text On 2016/04/01 09:55:07, philipj_UTC7 wrote: > You can drop the type attribute. Done.
6 <script src=../video-test.js></script>	6 test(function() {

7 <script type="text/javascript">	7 assert_equals(HTMLTrackElement.NONE, 0);

8 function doTest ()	8 assert_equals(HTMLTrackElement.LOADING, 1);

9 {	9 assert_equals(HTMLTrackElement.LOADED, 2);

10 testExpected("HTMLTrackElement.NONE", 0);	10 assert_equals(HTMLTrackElement.ERROR, 3);

11 testExpected("HTMLTrackElement.LOADING", 1);	11 });
	mlamouri (slow - plz ping) 2016/03/31 10:19:48 Could you add a test description? Could you add a test description? Srirama 2016/03/31 10:28:54 I have added the title above, do you prefer descri Show quoted text On 2016/03/31 10:19:48, Mounir Lamouri wrote: > Could you add a test description? I have added the title above, do you prefer description in test function instead of title? philipj_slow 2016/04/01 09:55:07 Having it in the <title> is the simplest way to do Show quoted text On 2016/03/31 10:28:54, Srirama wrote: > On 2016/03/31 10:19:48, Mounir Lamouri wrote: > > Could you add a test description? > > I have added the title above, do you prefer description in test function instead > of title? Having it in the <title> is the simplest way to do it for testharness.js if there's only one test. At least I like this style :) Srirama 2016/04/01 10:05:52 Acknowledged. Show quoted text On 2016/04/01 09:55:07, philipj_UTC7 wrote: > On 2016/03/31 10:28:54, Srirama wrote: > > On 2016/03/31 10:19:48, Mounir Lamouri wrote: > > > Could you add a test description? > > > > I have added the title above, do you prefer description in test function > instead > > of title? > > Having it in the <title> is the simplest way to do it for testharness.js if > there's only one test. At least I like this style :) Acknowledged.
12 testExpected("HTMLTrackElement.LOADED", 2);	12 </script>

13 testExpected("HTMLTrackElement.ERROR", 3);

14

15 endTest();

16 }

17 </script>

18 </head>

19 <body onload="doTest()">

20 <p>Test TextTrack constants.</p>

21 </body>

22 </html>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/track/track-constants-expected.txt » ('j') | no next file with comments »