Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1840393002: Convert track-constants.html from video-test.js to testharness.js based (Closed)

Created:
4 years, 8 months ago by Srirama
Modified:
4 years, 8 months ago
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert track-constants.html from video-test.js to testharness.js based Cleaning up track-constants.html to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/ed8ac7b7737e733afe58cada0422b2a6de15ac8e Cr-Commit-Position: refs/heads/master@{#384558}

Patch Set 1 #

Total comments: 6

Patch Set 2 : address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -29 lines) Patch
M third_party/WebKit/LayoutTests/media/track/track-constants.html View 1 1 chunk +11 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/track/track-constants-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
Srirama
PTAL and let me know if this is fine, so that i can go ahead ...
4 years, 8 months ago (2016-03-30 13:45:16 UTC) #3
mlamouri (slow - plz ping)
lgtm with a test description. https://codereview.chromium.org/1840393002/diff/1/third_party/WebKit/LayoutTests/media/track/track-constants.html File third_party/WebKit/LayoutTests/media/track/track-constants.html (right): https://codereview.chromium.org/1840393002/diff/1/third_party/WebKit/LayoutTests/media/track/track-constants.html#newcode11 third_party/WebKit/LayoutTests/media/track/track-constants.html:11: }); Could you add ...
4 years, 8 months ago (2016-03-31 10:19:48 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840393002/1
4 years, 8 months ago (2016-03-31 10:20:13 UTC) #6
mlamouri (slow - plz ping)
Also, please, change the CL title.
4 years, 8 months ago (2016-03-31 10:20:45 UTC) #7
Srirama
Do you want me to land this one test alone? I was thinking of modifying ...
4 years, 8 months ago (2016-03-31 10:28:55 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/202980)
4 years, 8 months ago (2016-03-31 11:32:03 UTC) #10
mlamouri (slow - plz ping)
Modifying more tests is fine. Though, please don't send a CL changing *all* tests :)
4 years, 8 months ago (2016-03-31 12:48:05 UTC) #11
philipj_slow
LGTM. Seeing more tests rewritten would be nice, but please batch them up into CLs ...
4 years, 8 months ago (2016-04-01 09:55:07 UTC) #12
Srirama
Sure, i will upload tests in batches. https://codereview.chromium.org/1840393002/diff/1/third_party/WebKit/LayoutTests/media/track/track-constants.html File third_party/WebKit/LayoutTests/media/track/track-constants.html (right): https://codereview.chromium.org/1840393002/diff/1/third_party/WebKit/LayoutTests/media/track/track-constants.html#newcode5 third_party/WebKit/LayoutTests/media/track/track-constants.html:5: <script type="text/javascript"> ...
4 years, 8 months ago (2016-04-01 10:05:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840393002/20001
4 years, 8 months ago (2016-04-01 10:06:29 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/197828)
4 years, 8 months ago (2016-04-01 10:50:04 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840393002/20001
4 years, 8 months ago (2016-04-01 11:58:26 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-01 12:03:16 UTC) #23
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 12:05:37 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ed8ac7b7737e733afe58cada0422b2a6de15ac8e
Cr-Commit-Position: refs/heads/master@{#384558}

Powered by Google App Engine
This is Rietveld 408576698