|
|
Created:
4 years, 8 months ago by Srirama Modified:
4 years, 8 months ago CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, vcarbune.chromium Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionConvert track-constants.html from video-test.js to testharness.js based
Cleaning up track-constants.html to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.
BUG=588956
Committed: https://crrev.com/ed8ac7b7737e733afe58cada0422b2a6de15ac8e
Cr-Commit-Position: refs/heads/master@{#384558}
Patch Set 1 #
Total comments: 6
Patch Set 2 : address nits #
Messages
Total messages: 25 (11 generated)
Description was changed from ========== fix BUG= ========== to ========== Convert media tests from video-test.js to testharness.js Cleaning up media tests to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 ==========
srirama.m@samsung.com changed reviewers: + mlamouri@chromium.org, philipj@opera.com
PTAL and let me know if this is fine, so that i can go ahead and cleanup other test cases.
lgtm with a test description. https://codereview.chromium.org/1840393002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/media/track/track-constants.html (right): https://codereview.chromium.org/1840393002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/media/track/track-constants.html:11: }); Could you add a test description?
The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840393002/1
Also, please, change the CL title.
Do you want me to land this one test alone? I was thinking of modifying the tests folder wise (sub folders inside media) or atleast some 10 test cases in one CL. I just want to check with you guys with one test case cleanup if there are any issues, before i can start modifying all the test cases. https://codereview.chromium.org/1840393002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/media/track/track-constants.html (right): https://codereview.chromium.org/1840393002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/media/track/track-constants.html:11: }); On 2016/03/31 10:19:48, Mounir Lamouri wrote: > Could you add a test description? I have added the title above, do you prefer description in test function instead of title?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Modifying more tests is fine. Though, please don't send a CL changing *all* tests :)
LGTM. Seeing more tests rewritten would be nice, but please batch them up into CLs that aren't too big to review. https://codereview.chromium.org/1840393002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/media/track/track-constants.html (right): https://codereview.chromium.org/1840393002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/media/track/track-constants.html:5: <script type="text/javascript"> You can drop the type attribute. https://codereview.chromium.org/1840393002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/media/track/track-constants.html:11: }); On 2016/03/31 10:28:54, Srirama wrote: > On 2016/03/31 10:19:48, Mounir Lamouri wrote: > > Could you add a test description? > > I have added the title above, do you prefer description in test function instead > of title? Having it in the <title> is the simplest way to do it for testharness.js if there's only one test. At least I like this style :)
Description was changed from ========== Convert media tests from video-test.js to testharness.js Cleaning up media tests to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 ========== to ========== Convert track-constants.html from video-test.js to testharness.js based Cleaning up track-constants.html to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 ==========
Sure, i will upload tests in batches. https://codereview.chromium.org/1840393002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/media/track/track-constants.html (right): https://codereview.chromium.org/1840393002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/media/track/track-constants.html:5: <script type="text/javascript"> On 2016/04/01 09:55:07, philipj_UTC7 wrote: > You can drop the type attribute. Done. https://codereview.chromium.org/1840393002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/media/track/track-constants.html:11: }); On 2016/04/01 09:55:07, philipj_UTC7 wrote: > On 2016/03/31 10:28:54, Srirama wrote: > > On 2016/03/31 10:19:48, Mounir Lamouri wrote: > > > Could you add a test description? > > > > I have added the title above, do you prefer description in test function > instead > > of title? > > Having it in the <title> is the simplest way to do it for testharness.js if > there's only one test. At least I like this style :) Acknowledged.
The CQ bit was checked by srirama.m@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from philipj@opera.com, mlamouri@chromium.org Link to the patchset: https://codereview.chromium.org/1840393002/#ps20001 (title: "address nits")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840393002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by srirama.m@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840393002/20001
Message was sent while issue was closed.
Description was changed from ========== Convert track-constants.html from video-test.js to testharness.js based Cleaning up track-constants.html to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 ========== to ========== Convert track-constants.html from video-test.js to testharness.js based Cleaning up track-constants.html to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Convert track-constants.html from video-test.js to testharness.js based Cleaning up track-constants.html to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 ========== to ========== Convert track-constants.html from video-test.js to testharness.js based Cleaning up track-constants.html to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/ed8ac7b7737e733afe58cada0422b2a6de15ac8e Cr-Commit-Position: refs/heads/master@{#384558} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ed8ac7b7737e733afe58cada0422b2a6de15ac8e Cr-Commit-Position: refs/heads/master@{#384558} |