Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 184033007: Prototype of Dart proxies for JS objects.

Created:
6 years, 9 months ago by blois
Modified:
5 years, 6 months ago
Reviewers:
CC:
justinfagnani
Visibility:
Public.

Description

NOT FOR SUBMISSION. Prototype of Dart proxies for JS objects. BUG=

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : More tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+714 lines, -156 lines) Patch
A pkg/element_created/lib/element_created.dart View 1 1 chunk +41 lines, -0 lines 0 comments Download
A pkg/element_created/lib/element_created.js View 1 chunk +67 lines, -0 lines 0 comments Download
A pkg/element_created/pubspec.yaml View 1 chunk +5 lines, -0 lines 0 comments Download
A pkg/element_created/test/index.html View 1 chunk +109 lines, -0 lines 0 comments Download
A pkg/element_created/test/unittest.js View 1 chunk +10 lines, -0 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 4 chunks +77 lines, -37 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 6 chunks +56 lines, -42 lines 0 comments Download
A tests/html/custom/element_upgrade_test.dart View 1 2 3 1 chunk +118 lines, -0 lines 0 comments Download
A tests/html/custom/element_upgrade_test.html View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
M tools/dom/src/dart2js_CustomElementSupport.dart View 1 2 2 chunks +53 lines, -1 line 0 comments Download
A tools/dom/src/dartium_CustomElementSupport.dart View 1 2 3 1 chunk +88 lines, -0 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 2 3 2 chunks +3 lines, -39 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_EventTarget.darttemplate View 1 1 chunk +11 lines, -11 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 1 2 3 2 chunks +26 lines, -26 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
blois
Iteration #2 on this. Primary changes: #1 Eliminated the .proxy named constructor and just using ...
6 years, 9 months ago (2014-03-05 01:26:45 UTC) #1
blois
6 years, 9 months ago (2014-03-05 22:16:32 UTC) #2
On 2014/03/05 01:26:45, blois wrote:
> Iteration #2 on this. Primary changes:
> 
> #1 Eliminated the .proxy named constructor and just using .created. Proxy
causes
> some problems because it's difficult to enforce that the two constructors are
> used properly- that someone doesn't write something like:
> 
> class Foo {
>   Foo.created() : super.proxy();
> }
> 
> Also since classes would most likely function only in one context, it doesn't
> seem necessary to have two constructors.
> 
> #2 Removed document.registerElementProxy and instead exposing a lower level
> primitive 'document.createElementUpgrader'. This leaves it up to the
> user/framework to know when to upgrade the element.
> 
> The timing for this could come from the element_created package, or
> alternatively, Polymer/dart could negotiate a callback from Polymer/js when
> elements are upgraded.

Moving this over to https://codereview.chromium.org/177113014/ (drops the
package for hooking element creation), adds Dartium support.

Powered by Google App Engine
This is Rietveld 408576698