Source/core/rendering/svg/SVGInlineFlowBox.cpp - Issue 184023003: Make InlineBox::renderer() and related subclass methods return reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGInlineFlowBox.cpp

Issue 184023003: Make InlineBox::renderer() and related subclass methods return reference. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated by review comments. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/RenderObject.h ('K') | « Source/core/rendering/svg/SVGInlineFlowBox.h ('k') | Source/core/rendering/svg/SVGInlineTextBox.h » ('j') | Source/core/rendering/svg/SVGRenderTreeAsText.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/svg/SVGInlineFlowBox.cpp

diff --git a/Source/core/rendering/svg/SVGInlineFlowBox.cpp b/Source/core/rendering/svg/SVGInlineFlowBox.cpp

index 183291168e51e097584654995ab180c186c85637..d4a861c3db29e358defbcfc544c1080a0254b4df 100644

--- a/Source/core/rendering/svg/SVGInlineFlowBox.cpp

+++ b/Source/core/rendering/svg/SVGInlineFlowBox.cpp

@@ -50,10 +50,7 @@ void SVGInlineFlowBox::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffse

ASSERT(paintInfo.phase == PaintPhaseForeground || paintInfo.phase == PaintPhaseSelection);

ASSERT(!paintInfo.context->paintingDisabled());

- RenderObject* boxRenderer = renderer();

- ASSERT(boxRenderer);

- SVGRenderingContext renderingContext(boxRenderer, paintInfo, SVGRenderingContext::SaveGraphicsContext);

+ SVGRenderingContext renderingContext(&renderer(), paintInfo, SVGRenderingContext::SaveGraphicsContext);

if (renderingContext.isRenderingPrepared()) {

for (InlineBox* child = firstChild(); child; child = child->nextOnLine())

child->paint(paintInfo, paintOffset, 0, 0);