Source/core/rendering/svg/SVGRenderTreeAsText.cpp - Issue 184023003: Make InlineBox::renderer() and related subclass methods return reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGRenderTreeAsText.cpp

Issue 184023003: Make InlineBox::renderer() and related subclass methods return reference. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated by review comments. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/svg/SVGRenderTreeAsText.cpp

diff --git a/Source/core/rendering/svg/SVGRenderTreeAsText.cpp b/Source/core/rendering/svg/SVGRenderTreeAsText.cpp

index e10d2f00f1f109bfab86a20850abdd198bb0f2d4..348229dbca62662645c2ab577fb820cec5d95278 100644

--- a/Source/core/rendering/svg/SVGRenderTreeAsText.cpp

+++ b/Source/core/rendering/svg/SVGRenderTreeAsText.cpp

@@ -401,11 +401,10 @@ static inline void writeSVGInlineTextBox(TextStream& ts, SVGInlineTextBox* textB

if (fragments.isEmpty())

return;

- RenderSVGInlineText* textRenderer = toRenderSVGInlineText(textBox->textRenderer());

- ASSERT(textRenderer);

+ RenderSVGInlineText* textRenderer = &toRenderSVGInlineText(textBox->textRenderer());

Inactive 2014/02/28 14:16:42 RenderSVGInlineText& textRenderer = toRenderSVGInl

ostap 2014/02/28 15:37:23 Done.

const SVGRenderStyle* svgStyle = textRenderer->style()->svgStyle();

- String text = textBox->textRenderer()->text();

+ String text = textBox->textRenderer().text();

unsigned fragmentsSize = fragments.size();

for (unsigned i = 0; i < fragmentsSize; ++i) {

« Source/core/rendering/RenderObject.h ('K') | « Source/core/rendering/svg/SVGInlineTextBox.cpp ('k') | Source/core/rendering/svg/SVGRootInlineBox.h » ('j') | no next file with comments »