Source/core/rendering/svg/RenderSVGText.cpp - Issue 184023003: Make InlineBox::renderer() and related subclass methods return reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGText.cpp

Issue 184023003: Make InlineBox::renderer() and related subclass methods return reference. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated by review comments. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/RenderObject.h ('K') | « Source/core/rendering/svg/RenderSVGInlineText.cpp ('k') | Source/core/rendering/svg/SVGInlineFlowBox.h » ('j') | Source/core/rendering/svg/SVGRenderTreeAsText.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/svg/RenderSVGText.cpp

diff --git a/Source/core/rendering/svg/RenderSVGText.cpp b/Source/core/rendering/svg/RenderSVGText.cpp

index fbe9cdab85f7526fbd78f84a096cba6272f33722..9a2c60795ad66f8f954010f9abb719dd92c74190 100644

--- a/Source/core/rendering/svg/RenderSVGText.cpp

+++ b/Source/core/rendering/svg/RenderSVGText.cpp

@@ -419,7 +419,7 @@ void RenderSVGText::layout()

RootInlineBox* RenderSVGText::createRootInlineBox()

{

- RootInlineBox* box = new SVGRootInlineBox(this);

+ RootInlineBox* box = new SVGRootInlineBox(*this);

box->setHasVirtualLogicalHeight();

return box;

}

@@ -460,7 +460,7 @@ PositionWithAffinity RenderSVGText::positionForPoint(const LayoutPoint& pointInC

if (!closestBox)

return createPositionWithAffinity(0, DOWNSTREAM);

- return closestBox->renderer()->positionForPoint(LayoutPoint(pointInContents.x(), closestBox->y()));

+ return closestBox->renderer().positionForPoint(LayoutPoint(pointInContents.x(), closestBox->y()));

}

void RenderSVGText::absoluteQuads(Vector<FloatQuad>& quads, bool* wasFixed) const