Source/core/rendering/RootInlineBox.h - Issue 184023003: Make InlineBox::renderer() and related subclass methods return reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RootInlineBox.h

Issue 184023003: Make InlineBox::renderer() and related subclass methods return reference. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated by review comments. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/RenderObject.h ('K') | « Source/core/rendering/RenderText.cpp ('k') | Source/core/rendering/RootInlineBox.cpp » ('j') | Source/core/rendering/svg/SVGRenderTreeAsText.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RootInlineBox.h

diff --git a/Source/core/rendering/RootInlineBox.h b/Source/core/rendering/RootInlineBox.h

index 92ea13091364096a42a5038ace84a5e3a89a1bb8..32b1c55221d0ee4da61fd42fe4d73b80f0639c37 100644

--- a/Source/core/rendering/RootInlineBox.h

+++ b/Source/core/rendering/RootInlineBox.h

@@ -35,7 +35,7 @@ struct GapRects;

class RootInlineBox : public InlineFlowBox {

public:

- explicit RootInlineBox(RenderBlockFlow*);

+ explicit RootInlineBox(RenderBlockFlow&);

virtual void destroy() OVERRIDE FINAL;

@@ -125,7 +125,7 @@ public:

GapRects lineSelectionGap(RenderBlock* rootBlock, const LayoutPoint& rootBlockPhysicalPosition, const LayoutSize& offsetFromRootBlock, LayoutUnit selTop, LayoutUnit selHeight, const PaintInfo*);

- RenderBlockFlow* block() const;

+ RenderBlockFlow& block() const;

InlineBox* closestLeafChildForPoint(const IntPoint&, bool onlyEditableLeaves);

InlineBox* closestLeafChildForLogicalLeftPosition(int, bool onlyEditableLeaves = false);