Source/core/rendering/RenderReplaced.cpp - Issue 184023003: Make InlineBox::renderer() and related subclass methods return reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderReplaced.cpp

Issue 184023003: Make InlineBox::renderer() and related subclass methods return reference. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated by review comments. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/RenderObject.h ('K') | « Source/core/rendering/RenderObject.cpp ('k') | Source/core/rendering/RenderText.cpp » ('j') | Source/core/rendering/svg/SVGRenderTreeAsText.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderReplaced.cpp

diff --git a/Source/core/rendering/RenderReplaced.cpp b/Source/core/rendering/RenderReplaced.cpp

index 5d1dae4fac814b0a643fcd0ce1415562eb2837a7..eecded236d960ce6f9210cc2f1168539c2bfb712 100644

--- a/Source/core/rendering/RenderReplaced.cpp

+++ b/Source/core/rendering/RenderReplaced.cpp

@@ -572,8 +572,8 @@ LayoutRect RenderReplaced::localSelectionRect(bool checkWhetherSelected) const

return LayoutRect(LayoutPoint(), size());

RootInlineBox* root = inlineBoxWrapper()->root();

- LayoutUnit newLogicalTop = root->block()->style()->isFlippedBlocksWritingMode() ? inlineBoxWrapper()->logicalBottom() - root->selectionBottom() : root->selectionTop() - inlineBoxWrapper()->logicalTop();

- if (root->block()->style()->isHorizontalWritingMode())

+ LayoutUnit newLogicalTop = root->block().style()->isFlippedBlocksWritingMode() ? inlineBoxWrapper()->logicalBottom() - root->selectionBottom() : root->selectionTop() - inlineBoxWrapper()->logicalTop();

+ if (root->block().style()->isHorizontalWritingMode())

return LayoutRect(0, newLogicalTop, width(), root->selectionHeight());

return LayoutRect(newLogicalTop, 0, root->selectionHeight(), height());

}