Chromium Code Reviews| Index: cc/scheduler/begin_frame_source.h |
| diff --git a/cc/scheduler/begin_frame_source.h b/cc/scheduler/begin_frame_source.h |
| index 1efd6a1bda6d22d8b333de632e66780eb00caabf..fb0c8c3f40c14b5fd5daa0efed4a82432d2c9129 100644 |
| --- a/cc/scheduler/begin_frame_source.h |
| +++ b/cc/scheduler/begin_frame_source.h |
| @@ -178,7 +178,7 @@ class CC_EXPORT BeginFrameSourceBase : public BeginFrameSource { |
| // remaining frames reaches zero. |
| class CC_EXPORT BackToBackBeginFrameSource : public BeginFrameSourceBase { |
| public: |
| - static scoped_ptr<BackToBackBeginFrameSource> Create( |
| + explicit BackToBackBeginFrameSource( |
| base::SingleThreadTaskRunner* task_runner); |
| ~BackToBackBeginFrameSource() override; |
| @@ -193,8 +193,6 @@ class CC_EXPORT BackToBackBeginFrameSource : public BeginFrameSourceBase { |
| void AsValueInto(base::trace_event::TracedValue* dict) const override; |
| protected: |
| - explicit BackToBackBeginFrameSource( |
| - base::SingleThreadTaskRunner* task_runner); |
| virtual base::TimeTicks Now(); // Now overridable for testing |
| base::SingleThreadTaskRunner* task_runner_; |
| @@ -214,9 +212,10 @@ class CC_EXPORT BackToBackBeginFrameSource : public BeginFrameSourceBase { |
| class CC_EXPORT SyntheticBeginFrameSource : public BeginFrameSourceBase, |
| public DelayBasedTimeSourceClient { |
| public: |
| - static scoped_ptr<SyntheticBeginFrameSource> Create( |
| - base::SingleThreadTaskRunner* task_runner, |
| - base::TimeDelta initial_vsync_interval); |
| + explicit SyntheticBeginFrameSource(base::SingleThreadTaskRunner* task_runner, |
| + base::TimeDelta initial_vsync_interval); |
| + explicit SyntheticBeginFrameSource( |
| + scoped_ptr<DelayBasedTimeSource> time_source); |
|
danakj
2016/03/29 21:32:32
This one is only meant for subclasses?
enne (OOO)
2016/03/29 21:35:14
That is how it is currently used, yes. But, I don
|
| ~SyntheticBeginFrameSource() override; |
| void OnUpdateVSyncParameters(base::TimeTicks new_vsync_timebase, |
| @@ -233,9 +232,6 @@ class CC_EXPORT SyntheticBeginFrameSource : public BeginFrameSourceBase, |
| void OnTimerTick() override; |
| protected: |
| - explicit SyntheticBeginFrameSource( |
| - scoped_ptr<DelayBasedTimeSource> time_source); |
| - |
| BeginFrameArgs CreateBeginFrameArgs(base::TimeTicks frame_time, |
| BeginFrameArgs::BeginFrameArgsType type); |