Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1840203002: More analyzer updates, and handle negative_tests (Closed)

Created:
4 years, 8 months ago by Jennifer Messerly
Modified:
4 years, 8 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

More analyzer updates, and handle negative_tests Also fixes node_test to not overwrite main SDK log R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/562cdd8838cd4e74605c7cec51f71f7e839f5d33

Patch Set 1 #

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1197 lines, -755 lines) Patch
M lib/src/analysis_context.dart View 1 chunk +1 line, -1 line 1 comment Download
M lib/src/codegen/side_effect_analysis.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M lib/src/compiler.dart View 2 chunks +7 lines, -15 lines 0 comments Download
M lib/src/dart_sdk.dart View 3 chunks +26 lines, -5 lines 0 comments Download
M lib/src/report.dart View 5 chunks +134 lines, -14 lines 2 comments Download
M lib/src/utils.dart View 2 chunks +0 lines, -17 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/all_tests.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/browser/language_tests.js View 2 chunks +12 lines, -1 line 0 comments Download
M test/codegen/expect/collection/src/algorithms.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen/expect/collection/src/canonicalized_map.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen/expect/collection/src/equality.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M test/codegen/expect/collection/src/iterable_zip.txt View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/collection/src/priority_queue.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen/expect/collection/src/queue_list.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M test/codegen/expect/collection/src/unmodifiable_wrappers.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M test/codegen/expect/collection/src/wrappers.txt View 1 chunk +21 lines, -21 lines 0 comments Download
M test/codegen/expect/constructors.txt View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/js_test.txt View 1 chunk +326 lines, -326 lines 0 comments Download
M test/codegen/expect/language-all.js View Binary file 0 comments Download
M test/codegen_test.dart View 1 5 chunks +24 lines, -9 lines 0 comments Download
D test/end_to_end_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
M test/testing.dart View 1 chunk +0 lines, -24 lines 0 comments Download
M tool/node_test.sh View 1 chunk +8 lines, -1 line 0 comments Download
M tool/sdk_expected_errors.txt View 1 chunk +600 lines, -246 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
4 years, 8 months ago (2016-03-29 21:32:00 UTC) #2
vsm
lgtm https://codereview.chromium.org/1840203002/diff/20001/lib/src/analysis_context.dart File lib/src/analysis_context.dart (left): https://codereview.chromium.org/1840203002/diff/20001/lib/src/analysis_context.dart#oldcode43 lib/src/analysis_context.dart:43: var sdkResolver = options.useMockSdk doh! https://codereview.chromium.org/1840203002/diff/20001/lib/src/report.dart File lib/src/report.dart ...
4 years, 8 months ago (2016-03-29 22:10:54 UTC) #3
Jennifer Messerly
Thanks :) https://codereview.chromium.org/1840203002/diff/20001/lib/src/report.dart File lib/src/report.dart (right): https://codereview.chromium.org/1840203002/diff/20001/lib/src/report.dart#newcode56 lib/src/report.dart:56: if (code is StaticWarningCode) { On 2016/03/29 ...
4 years, 8 months ago (2016-03-29 22:16:21 UTC) #4
Jennifer Messerly
4 years, 8 months ago (2016-03-29 22:16:50 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
562cdd8838cd4e74605c7cec51f71f7e839f5d33 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698