Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1315)

Unified Diff: test/browser/language_tests.js

Issue 1840203002: More analyzer updates, and handle negative_tests (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/browser/language_tests.js
diff --git a/test/browser/language_tests.js b/test/browser/language_tests.js
index df80c39a0f8b5ac9dabd223b203f2bde1a04a0fd..f993b2b42f6d6c2e56f7fc05f18d59cbee04e182 100644
--- a/test/browser/language_tests.js
+++ b/test/browser/language_tests.js
@@ -317,6 +317,12 @@
'multiline_newline_test_06_multi',
'multiline_newline_test_none_multi',
'no_main_test_01_multi',
+
+ // https://github.com/dart-lang/sdk/issues/26123
+ 'bad_raw_string_negative_test',
+
+ // https://github.com/dart-lang/sdk/issues/26124
+ 'prefix10_negative_test'
]),
helpers: new Set([
'library_prefixes_test1',
@@ -392,7 +398,12 @@
async_helper.asyncTestInitialize(done);
console.debug('Running ' + s + ' test: ' + name);
- dart_library.import(s + '/' + name).main();
+ let mainLibrary = dart_library.import(s + '/' + name);
+ if (/negative_test/.test(name)) {
+ assert.throws(mainLibrary.main);
+ } else {
+ mainLibrary.main();
+ }
if (!async_helper.asyncTestStarted) done();
});

Powered by Google App Engine
This is Rietveld 408576698