Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 1840113005: Move viewport actions into an ApplyScroll callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Document.h
diff --git a/third_party/WebKit/Source/core/dom/Document.h b/third_party/WebKit/Source/core/dom/Document.h
index 646af18ae3e9d41e96803f69705f72f47eea5de7..2b75409efc6abc076c963224935bc95093f9813f 100644
--- a/third_party/WebKit/Source/core/dom/Document.h
+++ b/third_party/WebKit/Source/core/dom/Document.h
@@ -1162,6 +1162,13 @@ private:
RawPtr<OriginTrialContext> createOriginTrialContext() override;
+ // Installs the viewport scrolling callback (the "applyScroll" in Scroll
+ // Customization lingo) on the root scrollingElement. This callback is
+ // responsible for viewport related scroll actions like top controls
+ // movement and overscroll glow as well as actually scrolling the root
+ // viewport.
+ void updateViewportApplyScroll();
+
DocumentLifecycle m_lifecycle;
bool m_hasNodesWithPlaceholderStyle;
@@ -1267,6 +1274,7 @@ private:
Timer<Document> m_updateFocusAppearanceTimer;
Member<Element> m_cssTarget;
+ Member<Element> m_oldScrollingElement;
tdresser 2016/04/05 19:31:12 Add a comment indicating why this can't be a WeakM
bokan 2016/04/06 15:21:01 Actually, I think it can and should. Changed to We
bokan 2016/04/07 00:39:14 Forgot to remove this comment after pondering the
LoadEventProgress m_loadEventProgress;

Powered by Google App Engine
This is Rietveld 408576698