Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 1840113005: Move viewport actions into an ApplyScroll callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
9 * Copyright (C) 2011 Google Inc. All rights reserved. 9 * Copyright (C) 2011 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1144 matching lines...) Expand 10 before | Expand all | Expand 10 after
1155 1155
1156 using EventFactorySet = HashSet<OwnPtr<EventFactoryBase>>; 1156 using EventFactorySet = HashSet<OwnPtr<EventFactoryBase>>;
1157 static EventFactorySet& eventFactories(); 1157 static EventFactorySet& eventFactories();
1158 1158
1159 void setNthIndexCache(NthIndexCache* nthIndexCache) { ASSERT(!m_nthIndexCach e || !nthIndexCache); m_nthIndexCache = nthIndexCache; } 1159 void setNthIndexCache(NthIndexCache* nthIndexCache) { ASSERT(!m_nthIndexCach e || !nthIndexCache); m_nthIndexCache = nthIndexCache; }
1160 1160
1161 const OriginAccessEntry& accessEntryFromURL(); 1161 const OriginAccessEntry& accessEntryFromURL();
1162 1162
1163 RawPtr<OriginTrialContext> createOriginTrialContext() override; 1163 RawPtr<OriginTrialContext> createOriginTrialContext() override;
1164 1164
1165 // Installs the viewport scrolling callback (the "applyScroll" in Scroll
1166 // Customization lingo) on the root scrollingElement. This callback is
1167 // responsible for viewport related scroll actions like top controls
1168 // movement and overscroll glow as well as actually scrolling the root
1169 // viewport.
1170 void updateViewportApplyScroll();
1171
1165 DocumentLifecycle m_lifecycle; 1172 DocumentLifecycle m_lifecycle;
1166 1173
1167 bool m_hasNodesWithPlaceholderStyle; 1174 bool m_hasNodesWithPlaceholderStyle;
1168 bool m_evaluateMediaQueriesOnStyleRecalc; 1175 bool m_evaluateMediaQueriesOnStyleRecalc;
1169 1176
1170 // If we do ignore the pending stylesheet count, then we need to add a boole an 1177 // If we do ignore the pending stylesheet count, then we need to add a boole an
1171 // to track that this happened so that we can do a full repaint when the sty lesheets 1178 // to track that this happened so that we can do a full repaint when the sty lesheets
1172 // do eventually load. 1179 // do eventually load.
1173 PendingSheetLayout m_pendingSheetLayout; 1180 PendingSheetLayout m_pendingSheetLayout;
1174 1181
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
1260 String m_title; 1267 String m_title;
1261 String m_rawTitle; 1268 String m_rawTitle;
1262 Member<Element> m_titleElement; 1269 Member<Element> m_titleElement;
1263 1270
1264 Member<AXObjectCache> m_axObjectCache; 1271 Member<AXObjectCache> m_axObjectCache;
1265 Member<DocumentMarkerController> m_markers; 1272 Member<DocumentMarkerController> m_markers;
1266 1273
1267 Timer<Document> m_updateFocusAppearanceTimer; 1274 Timer<Document> m_updateFocusAppearanceTimer;
1268 1275
1269 Member<Element> m_cssTarget; 1276 Member<Element> m_cssTarget;
1277 Member<Element> m_oldScrollingElement;
tdresser 2016/04/05 19:31:12 Add a comment indicating why this can't be a WeakM
bokan 2016/04/06 15:21:01 Actually, I think it can and should. Changed to We
bokan 2016/04/07 00:39:14 Forgot to remove this comment after pondering the
1270 1278
1271 LoadEventProgress m_loadEventProgress; 1279 LoadEventProgress m_loadEventProgress;
1272 1280
1273 double m_startTime; 1281 double m_startTime;
1274 1282
1275 Member<ScriptRunner> m_scriptRunner; 1283 Member<ScriptRunner> m_scriptRunner;
1276 1284
1277 HeapVector<Member<HTMLScriptElement>> m_currentScriptStack; 1285 HeapVector<Member<HTMLScriptElement>> m_currentScriptStack;
1278 1286
1279 OwnPtr<TransformSource> m_transformSource; 1287 OwnPtr<TransformSource> m_transformSource;
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
1444 DEFINE_TYPE_CASTS(TreeScope, Document, document, true, true); 1452 DEFINE_TYPE_CASTS(TreeScope, Document, document, true, true);
1445 1453
1446 } // namespace blink 1454 } // namespace blink
1447 1455
1448 #ifndef NDEBUG 1456 #ifndef NDEBUG
1449 // Outside the WebCore namespace for ease of invocation from gdb. 1457 // Outside the WebCore namespace for ease of invocation from gdb.
1450 CORE_EXPORT void showLiveDocumentInstances(); 1458 CORE_EXPORT void showLiveDocumentInstances();
1451 #endif 1459 #endif
1452 1460
1453 #endif // Document_h 1461 #endif // Document_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698