Update Material Design History colors.

Update Material Design History colors.

BUG=598451

[calamity, 2016-03-30 01:41:22]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[Dan Beam, 2016-03-30 01:47:34]

https://codereview.chromium.org/1840043003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/history.html (right):

https://codereview.chromium.org/1840043003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history.html:17: background: rgb(236, 239,
241);
if you wanted to be super duper awesome, you could share these values between
downloads and history

[calamity, 2016-03-31 03:57:37]

https://codereview.chromium.org/1840043003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/history.html (right):

https://codereview.chromium.org/1840043003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history.html:17: background: rgb(236, 239,
241);
On 2016/03/30 01:47:33, Dan Beam wrote:
> if you wanted to be super duper awesome, you could share these values between
> downloads and history

Hmm. How? Do we have native CSS custom property support yet? We can't use a
shared custom stylesheet since these top level html pages aren't polymer
elements, right?

[calamity, 2016-03-31 03:57:37]

https://codereview.chromium.org/1840043003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/history.html (right):

https://codereview.chromium.org/1840043003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history.html:17: background: rgb(236, 239,
241);
On 2016/03/30 01:47:33, Dan Beam wrote:
> if you wanted to be super duper awesome, you could share these values between
> downloads and history

Hmm. How? Do we have native CSS custom property support yet? We can't use a
shared custom stylesheet since these top level html pages aren't polymer
elements, right?

[Dan Beam, 2016-03-31 04:30:20]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-03-31 04:30:21]

https://codereview.chromium.org/1840043003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/history.html (right):

https://codereview.chromium.org/1840043003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history.html:17: background: rgb(236, 239,
241);
On 2016/03/31 03:57:37, calamity wrote:
> On 2016/03/30 01:47:33, Dan Beam wrote:
> > if you wanted to be super duper awesome, you could share these values
between
> > downloads and history
> 
> Hmm. How? Do we have native CSS custom property support yet? We can't use a
> shared custom stylesheet since these top level html pages aren't polymer
> elements, right?

i trust you'll figure it out:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/polyme...

[calamity, 2016-03-31 07:07:06]

Patchset #2 (id:20001) has been deleted

[calamity, 2016-03-31 07:08:08]

Welp, here's a thing that works. I feel like it'll lead to duplication though,
until we have non-polyfill custom property support.

[Dan Beam, 2016-03-31 18:30:13]

overall i like where this is going :)

https://codereview.chromium.org/1840043003/diff/40001/ui/webui/resources/html...
File ui/webui/resources/html/md_shared_styles.html (right):

https://codereview.chromium.org/1840043003/diff/40001/ui/webui/resources/html...
ui/webui/resources/html/md_shared_styles.html:6: --md-toolbar-background-color:
rgb(52, 73, 94);
why not just put --md-background-color here as well? (instead of a class and
another html document)

[Dan Beam, 2016-03-31 18:32:52]

/cc michaelpg@ and dschuyler@

https://codereview.chromium.org/1840043003/diff/40001/ui/webui/resources/html...
File ui/webui/resources/html/md_shared_styles.html (right):

https://codereview.chromium.org/1840043003/diff/40001/ui/webui/resources/html...
ui/webui/resources/html/md_shared_styles.html:6: --md-toolbar-background-color:
rgb(52, 73, 94);
On 2016/03/31 18:30:13, Dan Beam wrote:
> why not just put --md-background-color here as well? (instead of a class and
> another html document)

also, i'm wondering the functional difference between what you're doing and
<style include="...">.

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

[calamity, 2016-04-01 02:46:29]

Someone correct me, I'm probably wrong.

https://codereview.chromium.org/1840043003/diff/40001/ui/webui/resources/html...
File ui/webui/resources/html/md_shared_styles.html (right):

https://codereview.chromium.org/1840043003/diff/40001/ui/webui/resources/html...
ui/webui/resources/html/md_shared_styles.html:6: --md-toolbar-background-color:
rgb(52, 73, 94);
On 2016/03/31 18:30:13, Dan Beam wrote:
> why not just put --md-background-color here as well? (instead of a class and
> another html document)

Wellllllll. You can't use the property in a top-level html page because no
custom property polyfill magic happens there (which was why I asked about native
custom properties, if that would even solve this problem).

I think that's why things like paper-styles.html have an accompanying
paper-styles-classes.html for the main document. (Also iron-flex-layout
classes/iron-flex-layout)

https://codereview.chromium.org/1840043003/diff/40001/ui/webui/resources/html...
ui/webui/resources/html/md_shared_styles.html:6: --md-toolbar-background-color:
rgb(52, 73, 94);
On 2016/03/31 18:32:52, Dan Beam wrote:
> On 2016/03/31 18:30:13, Dan Beam wrote:
> > why not just put --md-background-color here as well? (instead of a class and
> > another html document)
> 
> also, i'm wondering the functional difference between what you're doing and
> <style include="...">.
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

https://www.polymer-project.org/1.0/docs/devguide/styling.html#custom-style

custom-style seems to be for theming purposes like setting color mixins across
the whole main document. Shared styles look more appropriate for sharing classes
across custom elements.

[calamity, 2016-04-01 05:07:43]

tsergeant@ is likely to take over this patch as I'm going away on vacay.

[Moe, 2016-04-07 14:47:27]

Description was changed from

==========
Update Material Design History colors.

BUG=598451
==========

to

==========
Update Material Design History colors.

BUG=598451
==========

[tsergeant, 2016-04-22 03:25:47]

On 2016/04/01 05:07:43, calamity (OOO til May 9) wrote:
> tsergeant@ is likely to take over this patch as I'm going away on vacay.

Closing this patch now that the bug has been fixed in
https://codereview.chromium.org/1899043003