ui/webui/resources/html/md_shared_styles.html - Issue 1840043003: Update Material Design History colors.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/webui/resources/html/md_shared_styles.html

Issue 1840043003: Update Material Design History colors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: extract common styles from md downloads Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2

	3 <style is="custom-style">

	4

	5 :root {

	6 --md-toolbar-background-color: rgb(52, 73, 94);
	Dan Beam 2016/03/31 18:30:13 why not just put --md-background-color here as wel why not just put --md-background-color here as well? (instead of a class and another html document) Dan Beam 2016/03/31 18:32:52 also, i'm wondering the functional difference betw Show quoted text On 2016/03/31 18:30:13, Dan Beam wrote: > why not just put --md-background-color here as well? (instead of a class and > another html document) also, i'm wondering the functional difference between what you're doing and <style include="...">. https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res... https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res... calamity 2016/04/01 02:46:29 https://www.polymer-project.org/1.0/docs/devguide/ Show quoted text On 2016/03/31 18:32:52, Dan Beam wrote: > On 2016/03/31 18:30:13, Dan Beam wrote: > > why not just put --md-background-color here as well? (instead of a class and > > another html document) > > also, i'm wondering the functional difference between what you're doing and > <style include="...">. > > https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res... > https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res... https://www.polymer-project.org/1.0/docs/devguide/styling.html#custom-style custom-style seems to be for theming purposes like setting color mixins across the whole main document. Shared styles look more appropriate for sharing classes across custom elements. calamity 2016/04/01 02:46:29 Wellllllll. You can't use the property in a top-le Show quoted text On 2016/03/31 18:30:13, Dan Beam wrote: > why not just put --md-background-color here as well? (instead of a class and > another html document) Wellllllll. You can't use the property in a top-level html page because no custom property polyfill magic happens there (which was why I asked about native custom properties, if that would even solve this problem). I think that's why things like paper-styles.html have an accompanying paper-styles-classes.html for the main document. (Also iron-flex-layout classes/iron-flex-layout)
	7 }

	8

	9 </style>

OLD	NEW

« no previous file with comments | « chrome/browser/resources/md_history/history_toolbar.html ('k') | ui/webui/resources/html/md_shared_styles_classes.html » ('j') | no next file with comments »