Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Issue 1839813006: S390: Fix Mod64/ModU64 sequence (Closed)

Created:
4 years, 8 months ago by JoranSiu
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Fix Mod64/ModU64 sequence The CodeGenerator sequence for Mod64/ModU64 is incorrectly using 32-bit operations. Fix Mod64/ModU64 to use 64-bit divides to calculate the remainder. Fix disassembly for DLR, which was reading the wrong bits for the two register operands. R=jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com BUG= Committed: https://crrev.com/14570528745be33c583d23b441c0f3e7a4ea315a Cr-Commit-Position: refs/heads/master@{#35121}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/s390/disasm-s390.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839813006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839813006/1
4 years, 8 months ago (2016-03-30 00:37:39 UTC) #2
JoranSiu
4 years, 8 months ago (2016-03-30 00:39:25 UTC) #3
john.yan
lgtm
4 years, 8 months ago (2016-03-30 00:40:37 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-30 00:58:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839813006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839813006/1
4 years, 8 months ago (2016-03-30 01:06:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 01:08:20 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 01:08:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14570528745be33c583d23b441c0f3e7a4ea315a
Cr-Commit-Position: refs/heads/master@{#35121}

Powered by Google App Engine
This is Rietveld 408576698