Change HostContentSettingsMap::SetNarrowestContentSetting to use the appropriate scoping type

Change HostContentSettingsMap::SetNarrowestContentSetting to use the appropriate scoping type

This changes HostContentSettingsMap::SetNarrowestContentSetting to use the
scoping type which is a property of the content setting rather than its own
switch statement.

BUG=551747
Committed: https://crrev.com/a24193c914b3f05a1744e2e2eb46155565e0cc76
Cr-Commit-Position: refs/heads/master@{#384219}

[lshang, 2016-03-30 04:40:25]

Description was changed from

==========
format


use scope type

BUG=
==========

to

==========
Change HostContentSettingsMap::SetNarrowestContentSetting to use the appropriate
scoping type

This changes HostContentSettingsMap::SetNarrowestContentSetting to use the
scoping type which is a property of the content setting rather than its own
switch statement.

BUG=551747
==========

[lshang, 2016-03-30 05:24:39]

lshang@chromium.org changed reviewers:
+ raymes@chromium.org

[lshang, 2016-03-30 05:24:39]

PTAL thanks!

[raymes, 2016-03-30 06:51:58]

lgtm

https://codereview.chromium.org/1839783008/diff/1/components/content_settings...
File components/content_settings/core/browser/host_content_settings_map.cc
(right):

https://codereview.chromium.org/1839783008/diff/1/components/content_settings...
components/content_settings/core/browser/host_content_settings_map.cc:310: const
GURL& requesting_url,
nit: could you change this to primary/secondary while you're here?

[lshang, 2016-03-31 08:12:49]

The CQ bit was checked by lshang@chromium.org

[lshang, 2016-03-31 08:12:49]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/1839783008/#ps20001
(title: "use primart/secondary_url for setWebsiteSettingDefaultScope")

[commit-bot: I haz the power, 2016-03-31 08:12:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1839783008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1839783008/20001

[lshang, 2016-03-31 08:13:23]

https://codereview.chromium.org/1839783008/diff/1/components/content_settings...
File components/content_settings/core/browser/host_content_settings_map.cc
(right):

https://codereview.chromium.org/1839783008/diff/1/components/content_settings...
components/content_settings/core/browser/host_content_settings_map.cc:310: const
GURL& requesting_url,
On 2016/03/30 06:51:58, raymes wrote:
> nit: could you change this to primary/secondary while you're here?

Done.

[commit-bot: I haz the power, 2016-03-31 08:18:40]

Description was changed from

==========
Change HostContentSettingsMap::SetNarrowestContentSetting to use the appropriate
scoping type

This changes HostContentSettingsMap::SetNarrowestContentSetting to use the
scoping type which is a property of the content setting rather than its own
switch statement.

BUG=551747
==========

to

==========
Change HostContentSettingsMap::SetNarrowestContentSetting to use the appropriate
scoping type

This changes HostContentSettingsMap::SetNarrowestContentSetting to use the
scoping type which is a property of the content setting rather than its own
switch statement.

BUG=551747
==========

[commit-bot: I haz the power, 2016-03-31 08:18:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-31 08:20:22]

Description was changed from

==========
Change HostContentSettingsMap::SetNarrowestContentSetting to use the appropriate
scoping type

This changes HostContentSettingsMap::SetNarrowestContentSetting to use the
scoping type which is a property of the content setting rather than its own
switch statement.

BUG=551747
==========

to

==========
Change HostContentSettingsMap::SetNarrowestContentSetting to use the appropriate
scoping type

This changes HostContentSettingsMap::SetNarrowestContentSetting to use the
scoping type which is a property of the content setting rather than its own
switch statement.

BUG=551747

Committed: https://crrev.com/a24193c914b3f05a1744e2e2eb46155565e0cc76
Cr-Commit-Position: refs/heads/master@{#384219}
==========

[commit-bot: I haz the power, 2016-03-31 08:20:23]

Patchset 2 (id:??) landed as
https://crrev.com/a24193c914b3f05a1744e2e2eb46155565e0cc76
Cr-Commit-Position: refs/heads/master@{#384219}