Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1839783007:
[DevTools] Fix bug with WebSockets flipping frames (Closed)
|
Created:
4 years, 8 months ago by allada Modified:
4 years, 8 months ago Reviewers:
lushnikov CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] Fix bug with WebSockets flipping frames
Fix bug where if you are in network tab and debugging a WS then a frame
comes in, it would change the selected item in the network tab on the
user.
BUG=598076
R=lushnikov
Committed: https://crrev.com/07c26892dc84de2861dd2399656d56e8716cd1ff
Cr-Commit-Position: refs/heads/master@{#384064}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 17 (8 generated)
The CQ bit was checked by allada@chromium.org to run a CQ dry run
PTL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839783007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839783007/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
Description was changed from ========== i Enter a description of the change. [DevTools] Fix bug with WebSockets flipping frames Fix bug where if you are in network tab and debugging a WS then a frame comes in, it would change the selected item in the network tab on the user. BUG=598076 R=lushnikov ========== to ========== [DevTools] Fix bug with WebSockets flipping frames Fix bug where if you are in network tab and debugging a WS then a frame comes in, it would change the selected item in the network tab on the user. BUG=598076 R=lushnikov ==========
The CQ bit was checked by allada@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839783007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839783007/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/1839783007/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/1839783007/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:972: rootNode.removeChild(node); else nodesToInsert.push(node);
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839783007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839783007/1
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Fix bug with WebSockets flipping frames Fix bug where if you are in network tab and debugging a WS then a frame comes in, it would change the selected item in the network tab on the user. BUG=598076 R=lushnikov ========== to ========== [DevTools] Fix bug with WebSockets flipping frames Fix bug where if you are in network tab and debugging a WS then a frame comes in, it would change the selected item in the network tab on the user. BUG=598076 R=lushnikov ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Fix bug with WebSockets flipping frames Fix bug where if you are in network tab and debugging a WS then a frame comes in, it would change the selected item in the network tab on the user. BUG=598076 R=lushnikov ========== to ========== [DevTools] Fix bug with WebSockets flipping frames Fix bug where if you are in network tab and debugging a WS then a frame comes in, it would change the selected item in the network tab on the user. BUG=598076 R=lushnikov Committed: https://crrev.com/07c26892dc84de2861dd2399656d56e8716cd1ff Cr-Commit-Position: refs/heads/master@{#384064} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/07c26892dc84de2861dd2399656d56e8716cd1ff Cr-Commit-Position: refs/heads/master@{#384064} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
