Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 1839783007: [DevTools] Fix bug with WebSockets flipping frames (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index c960d3d9fbdf73f81ca4bf134203434c0f4c881b..4b7c2d79789fefe86675e9a11a226730c245cf87 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -966,11 +966,16 @@ WebInspector.NetworkLogView.prototype = {
var node = this._nodesByRequestId.get(requestId);
if (!node)
continue;
- if (!node[WebInspector.NetworkLogView._isFilteredOutSymbol])
- rootNode.removeChild(node);
- node[WebInspector.NetworkLogView._isFilteredOutSymbol] = !this._applyFilter(node);
- if (!node[WebInspector.NetworkLogView._isFilteredOutSymbol])
- nodesToInsert.push(node);
+ var isFilteredOut = !this._applyFilter(node);
+ if (node[WebInspector.NetworkLogView._isFilteredOutSymbol] !== isFilteredOut) {
+ if (!node[WebInspector.NetworkLogView._isFilteredOutSymbol])
+ rootNode.removeChild(node);
lushnikov 2016/03/30 19:27:18 else nodesToInsert.push(node);
+
+ node[WebInspector.NetworkLogView._isFilteredOutSymbol] = isFilteredOut;
+
+ if (!node[WebInspector.NetworkLogView._isFilteredOutSymbol])
+ nodesToInsert.push(node);
+ }
var request = node.request();
this._timeCalculator.updateBoundaries(request);
this._durationCalculator.updateBoundaries(request);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698