Convert the Linux ChromiumOS Builder on chromium.chromiumos to MB

Convert the Linux ChromiumOS Builder on chromium.chromiumos to MB

Add the builder's config to mb_config.pyl.

BUG=481692
R=dpranke

Committed: https://crrev.com/cb2e9ba644da39b4977d834fa2978d86b5077f23
Cr-Commit-Position: refs/heads/master@{#384211}

[aneeshm, 2016-03-30 02:12:16]

PTAL.

[Dirk Pranke, 2016-03-31 02:35:47]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-03-31 02:35:48]

lgtm w/ comments addressed.

https://codereview.chromium.org/1839773004/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/1839773004/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:963: ],
All of the configs that use swarming put swarming as the first part of the name,
so we should change this to

    'swarming_chromeos_gyp_release_bot': [
      'swarming', 'chromeos_with_codecs', 'gyp', 'release_bot',
    ]

Also, it's likely the case that really all of the chromeos bots should have the
_with_codecs flags, and so we should update the other configs. Please add a TODO
and file a bug to check that, but don't change that as part of this CL.

[aneeshm, 2016-03-31 06:03:40]

Done.

The bug: https://crbug.com/599348

https://codereview.chromium.org/1839773004/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/1839773004/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:963: ],
On 2016/03/31 02:35:48, Dirk Pranke wrote:
> All of the configs that use swarming put swarming as the first part of the
name,
> so we should change this to
> 
>     'swarming_chromeos_gyp_release_bot': [
>       'swarming', 'chromeos_with_codecs', 'gyp', 'release_bot',
>     ]
> 
> Also, it's likely the case that really all of the chromeos bots should have
the
> _with_codecs flags, and so we should update the other configs. Please add a
TODO
> and file a bug to check that, but don't change that as part of this CL.

Done.

[aneeshm, 2016-03-31 06:05:01]

The CQ bit was checked by aneeshm@chromium.org

[aneeshm, 2016-03-31 06:05:01]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1839773004/#ps20001
(title: "Review modifications")

[commit-bot: I haz the power, 2016-03-31 06:05:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1839773004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1839773004/20001

[commit-bot: I haz the power, 2016-03-31 06:30:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 06:30:59]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[aneeshm, 2016-03-31 06:31:51]

The CQ bit was checked by aneeshm@chromium.org

[commit-bot: I haz the power, 2016-03-31 06:32:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1839773004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1839773004/20001

[commit-bot: I haz the power, 2016-03-31 07:30:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-31 07:31:57]

Description was changed from

==========
Convert the Linux ChromiumOS Builder on chromium.chromiumos to MB

Add the builder's config to mb_config.pyl.

BUG=481692
R=dpranke
==========

to

==========
Convert the Linux ChromiumOS Builder on chromium.chromiumos to MB

Add the builder's config to mb_config.pyl.

BUG=481692
R=dpranke

Committed: https://crrev.com/cb2e9ba644da39b4977d834fa2978d86b5077f23
Cr-Commit-Position: refs/heads/master@{#384211}
==========

[commit-bot: I haz the power, 2016-03-31 07:31:58]

Patchset 2 (id:??) landed as
https://crrev.com/cb2e9ba644da39b4977d834fa2978d86b5077f23
Cr-Commit-Position: refs/heads/master@{#384211}

[Dirk Pranke, 2016-03-31 21:44:59]

On 2016/03/31 07:31:58, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/cb2e9ba644da39b4977d834fa2978d86b5077f23
> Cr-Commit-Position: refs/heads/master@{#384211}

Argh. I should have caught this, and I thought I mentioned this somewhere, but
we need to be careful to make sure that when
we add configs for waterfall bots, we also add the configs for any trybots that
mirror the waterfall bots, because when
we land the build-side change to flip the builder to start using MB, the trybot
will try to use MB, but uses the tryserver
master and buildername, not the waterfall master and buildername.

We do this because the tryservers don't actually mirror the waterfall bots in
this case: they often need to use different
GYP_DEFINES and gn args.

I'm fixing this case in https://codereview.chromium.org/1846013002/ for
linux_chromium_chromeos_rel_ng, but we
should check to see if there are any other tryservers that also "mirror" Linux
ChromiumOS Builder.