Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 183973007: Also use transition types when constructing Events that raise exceptions. (Closed)

Created:
6 years, 9 months ago by sof
Modified:
6 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Also use transition types when constructing Events that raise exceptions. Follow up the switch to making Events be garbage collected in http://codereview.chromium.org/182763002 and also use a transition type for the result if the event constructor raises exceptions. R=haraken@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/bindings/templates/interface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look. (Four fast/events tests assert & fail on trunk, which is how ...
6 years, 9 months ago (2014-02-28 16:26:59 UTC) #1
haraken
On 2014/02/28 16:26:59, sof wrote: > Please take a look. > > (Four fast/events tests ...
6 years, 9 months ago (2014-02-28 16:34:10 UTC) #2
sof
On 2014/02/28 16:34:10, haraken wrote: > On 2014/02/28 16:26:59, sof wrote: > > Please take ...
6 years, 9 months ago (2014-02-28 16:37:32 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 9 months ago (2014-02-28 16:38:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/183973007/1
6 years, 9 months ago (2014-02-28 16:38:16 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 18:23:09 UTC) #6
Message was sent while issue was closed.
Change committed as 168149

Powered by Google App Engine
This is Rietveld 408576698