Add [WillBeGarbageCollected] to Event.idl

Add [WillBeGarbageCollected] to Event.idl

- This CL adds [WillBeGarbageCollected] to Event.idl and makes minimal changes to the code base to make it workable.

- This CL is almost just replacing:

  PassRefPtr<XEvent> XEvent::create() { return adoptRef(new XEvent); }

with

  PassRefPtrWillBeRawPtr<XEvent> XEvent::create() { return adoptRefWillBeRefCountedGarbageCollected(new XEvent); }

- This CL adds a trace() metho to SpeechRecognitionError, because I found that it inherits Event.

BUG=340522
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168100

[haraken, 2014-02-27 07:54:11]

PTAL

This is a minimal change to make [WillBeGarbageCollected] in Event.idl workable.

[Mads Ager (chromium), 2014-02-27 10:08:13]

LGTM

[haraken, 2014-02-27 10:24:40]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-02-27 10:24:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/182763002/20001

[commit-bot: I haz the power, 2014-02-27 10:52:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-27 10:52:46]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[haraken, 2014-02-27 10:54:09]

jochen@: rubberstamp to web/ please?

[tkent, 2014-02-28 00:59:47]

https://codereview.chromium.org/182763002/diff/20001/Source/bindings/scripts/...
File Source/bindings/scripts/code_generator_v8.pm (right):

https://codereview.chromium.org/182763002/diff/20001/Source/bindings/scripts/...
Source/bindings/scripts/code_generator_v8.pm:1: # Copyright (C) 2005, 2006
Nikolas Zimmermann <zimmermann@kde.org>
code_generator_v8.pm was removed.

https://codereview.chromium.org/182763002/diff/20001/Source/web/tests/CustomE...
File Source/web/tests/CustomEventTest.cpp (right):

https://codereview.chromium.org/182763002/diff/20001/Source/web/tests/CustomE...
Source/web/tests/CustomEventTest.cpp:108: // FIXME: oilpan: Remove
PassRefPtr<Event>() once we support PassRefPtrWillBeRawPtr in WebDOMEvent.
Why don't you use PassRefPtrWillBeRawPtr in WebDOMEvent in this patch?

[haraken, 2014-02-28 01:10:02]

https://codereview.chromium.org/182763002/diff/20001/Source/web/tests/CustomE...
File Source/web/tests/CustomEventTest.cpp (right):

https://codereview.chromium.org/182763002/diff/20001/Source/web/tests/CustomE...
Source/web/tests/CustomEventTest.cpp:108: // FIXME: oilpan: Remove
PassRefPtr<Event>() once we support PassRefPtrWillBeRawPtr in WebDOMEvent.
On 2014/02/28 00:59:48, tkent wrote:
> Why don't you use PassRefPtrWillBeRawPtr in WebDOMEvent in this patch?

WebDOMEvent has its own hierarchy, so using PassRefPtrWillBeRawPtr in
WebDOMEvent increases the patch size. So I want to do that in a separate CL.

[tkent, 2014-02-28 01:13:35]

https://codereview.chromium.org/182763002/diff/20001/Source/web/tests/CustomE...
File Source/web/tests/CustomEventTest.cpp (right):

https://codereview.chromium.org/182763002/diff/20001/Source/web/tests/CustomE...
Source/web/tests/CustomEventTest.cpp:108: // FIXME: oilpan: Remove
PassRefPtr<Event>() once we support PassRefPtrWillBeRawPtr in WebDOMEvent.
On 2014/02/28 01:10:03, haraken wrote:
> On 2014/02/28 00:59:48, tkent wrote:
> > Why don't you use PassRefPtrWillBeRawPtr in WebDOMEvent in this patch?
> 
> WebDOMEvent has its own hierarchy, so using PassRefPtrWillBeRawPtr in
> WebDOMEvent increases the patch size. So I want to do that in a separate CL.

It makes sense.  lgtm

[haraken, 2014-02-28 01:14:02]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-02-28 01:15:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/182763002/20001

[commit-bot: I haz the power, 2014-02-28 01:16:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-28 01:16:21]

Failed to apply patch for Source/bindings/scripts/code_generator_v8.pm:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: Source/bindings/scripts/code_generator_v8.pm
  |diff --git a/Source/bindings/scripts/code_generator_v8.pm
b/Source/bindings/scripts/code_generator_v8.pm
  |index
a554f2f090e7a318991dc654c0693d359a64a558..1c033600403d65be34fbb0450f1beb3465041f70
100644
  |--- a/Source/bindings/scripts/code_generator_v8.pm
  |+++ b/Source/bindings/scripts/code_generator_v8.pm
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       Source/bindings/scripts/code_generator_v8.pm
Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm
b/Source/bindings/scripts/code_generator_v8.pm
index
a554f2f090e7a318991dc654c0693d359a64a558..1c033600403d65be34fbb0450f1beb3465041f70
100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -3059,7 +3059,7 @@ END
     }
 
     $implementation{nameSpaceInternal}->add(<<END);
-    RefPtr<${implClassName}> event = ${implClassName}::create(type,
eventInit${exceptionStateArgument});
+    RefPtrWillBeRawPtr<${implClassName}> event = ${implClassName}::create(type,
eventInit${exceptionStateArgument});
 END
 
     if ($constructorRaisesException) {

[haraken, 2014-02-28 04:13:55]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-02-28 04:14:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/182763002/40001

[haraken, 2014-02-28 04:32:42]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-02-28 04:32:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/182763002/60001

[commit-bot: I haz the power, 2014-02-28 08:30:32]

Change committed as 168100