Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compilation. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
index 893809f0db8e49bd834b28dff37ae9ef92bc586a..5716d53e87697b61c7930c9e1728b4656a472695 100644
--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
@@ -319,13 +319,15 @@ WebDevToolsAgentImpl::WebDevToolsAgentImpl(
, m_stateMuted(false)
, m_layerTreeId(0)
{
- ASSERT(isMainThread());
- ASSERT(m_webLocalFrameImpl->frame());
+ DCHECK(isMainThread());
+ DCHECK(m_webLocalFrameImpl->frame());
}
WebDevToolsAgentImpl::~WebDevToolsAgentImpl()
{
- ASSERT(m_hasBeenDisposed);
+#if ENABLE(ASSERT)
tkent 2016/03/31 23:05:21 Please do not add ENABLE(ASSERT). m_hasBeenDispose
+ DCHECK(m_hasBeenDisposed);
+#endif
}
void WebDevToolsAgentImpl::dispose()
@@ -335,7 +337,7 @@ void WebDevToolsAgentImpl::dispose()
if (m_attached)
Platform::current()->currentThread()->removeTaskObserver(this);
#if ENABLE(ASSERT)
tkent 2016/03/31 23:05:21 This should be DCHECK_IS_ON().
- ASSERT(!m_hasBeenDisposed);
+ DCHECK(!m_hasBeenDisposed);
m_hasBeenDisposed = true;
#endif
}
@@ -369,8 +371,8 @@ DEFINE_TRACE(WebDevToolsAgentImpl)
void WebDevToolsAgentImpl::willBeDestroyed()
{
- ASSERT(m_webLocalFrameImpl->frame());
- ASSERT(m_inspectedFrames->root()->view());
+ DCHECK(m_webLocalFrameImpl->frame());
+ DCHECK(m_inspectedFrames->root()->view());
detach();
m_resourceContentLoader->dispose();

Powered by Google App Engine
This is Rietveld 408576698